Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pinocchio #365

Merged
merged 2 commits into from
May 14, 2023
Merged

Add pinocchio #365

merged 2 commits into from
May 14, 2023

Conversation

Tobias-Fischer
Copy link
Collaborator

No description provided.

@Tobias-Fischer
Copy link
Collaborator Author

Hi @traversaro - I’d be happy to merge this in. We never found a great way to deal with RoboStack/robostack.github.io#17 so for our users this might be the easiest way? What do you think?

@Tobias-Fischer
Copy link
Collaborator Author

Fix #364

@traversaro
Copy link
Member

Hi @traversaro - I’d be happy to merge this in. We never found a great way to deal with RoboStack/robostack.github.io#17 so for our users this might be the easiest way? What do you think?

Yes, the only way we found for now is to use additional recipes such as https://github.com/RoboStack/ros-humble/pull/42/files, but the fact that we need to manually deal with versions and run_exports does not make them a great solution. Feel free to merge, once this creates some problems I guess it will give the motivation to work more seriously on fixing the problem.

@Tobias-Fischer Tobias-Fischer merged commit b73842a into master May 14, 2023
@Tobias-Fischer Tobias-Fischer deleted the pinocchio branch May 14, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobias-Fischer @traversaro