Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild January 2025 - switch to rattler-build #229

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Dec 17, 2024

Full rebuild on all platforms, heavily based on:

List of PRs and issues that will be fixed once this PR is merged:

@Tobias-Fischer
Copy link
Contributor

I’d say let’s wait for @wolfv to take a look at the cirun.io issue and then also run the PRs on the native aarch runners to avoid all those annoying and time consuming cross compile issues.

@traversaro
Copy link
Member Author

I’d say let’s wait for @wolfv to take a look at the cirun.io issue and then also run the PRs on the native aarch runners to avoid all those annoying and time consuming cross compile issues.

Yes, that would be ideal!

@traversaro
Copy link
Member Author

osx-64 is failing with:

2025-01-05T14:25:57.4352460Z Error: 
2025-01-05T14:25:57.4373750Z   × Failed to resolve dependencies: failed to unclobber clobbered files
2025-01-05T14:25:57.4374520Z   ├─▶ failed to unclobber clobbered files
2025-01-05T14:25:57.4375450Z   ├─▶ failed to rename include/X11/Xutil.h__clobber-from-xorg-libx11 to
2025-01-05T14:25:57.4377550Z   │   include/X11/Xutil.h
2025-01-05T14:25:57.4378170Z   ╰─▶ failed to rename file from /Users/runner/work/ros-humble/ros-humble/
2025-01-05T14:25:57.4378970Z       output/bld/rattler-build_ros-humble-theora-image-transport_1736073165/
2025-01-05T14:25:57.4379820Z       host_env_placehold_placehold_placehold_placehold_placehold_placehold_pla
2025-01-05T14:25:57.4380680Z       cehold_placehold_placehold_placehold_placehold_placehold_placehold_place
2025-01-05T14:25:57.4382590Z       /include/X11/Xutil.h__clobber-from-xorg-libx11 to /Users/runner/work/
2025-01-05T14:25:57.4384070Z       ros-humble/ros-humble/output/bld/rattler-build_ros-humble-theora-image-
2025-01-05T14:25:57.4385310Z       transport_1736073165/
2025-01-05T14:25:57.4386300Z       host_env_placehold_placehold_placehold_placehold_placehold_placehold_pla
2025-01-05T14:25:57.4387200Z       cehold_placehold_placehold_placehold_placehold_placehold_placehold_place
2025-01-05T14:25:57.4387980Z       /include/X11/Xutil.h: No such file or directory (os error 2)

@wolfv
Copy link
Member

wolfv commented Jan 5, 2025

@traversaro that is a transient clobber error that @Tobias-Fischer already reported :/ sorry about that. I'll have to dig in to see where this fails tomorrow.

@traversaro
Copy link
Member Author

@traversaro that is a transient clobber error that @Tobias-Fischer already reported :/ sorry about that. I'll have to dig in to see where this fails tomorrow.

Ah right, I even commented there! But I did not recognized it. Let's cross-link the issue: prefix-dev/rattler-build#1288 .

@traversaro
Copy link
Member Author

Another strange problem is that somehow on Windows package that depend on yaml-cpp or console-bridge also copy as part of the compiled package, and then clearly those packages start coblerring with the same files from their depedencies, see:

2025-01-05T12:17:36.2141313Z  │ │   - Library/cmake/yamlConfig.cmake__clobber-from-ros-humble-tf2-geometry-msgs
2025-01-05T12:17:36.2143337Z  │ │   - Library/cmake/yamlConfigVersion.cmake__clobber-from-ros-humble-tf2-geometry-msgs
2025-01-05T12:17:36.2145134Z  │ │   - Library/cmake/yamlTargets-release.cmake__clobber-from-ros-humble-tf2-geometry-msgs
2025-01-05T12:17:36.2146995Z  │ │   - Library/cmake/yamlTargets.cmake__clobber-from-ros-humble-tf2-geometry-msgs

@Tobias-Fischer
Copy link
Contributor

I am happy with all platforms except for linux-aarch64 in a previous run (https://github.com/RoboStack/ros-humble/actions/runs/12622123371), let's see how linux-aarch64 is going in this run and then I think it's ready for merging.

@Tobias-Fischer
Copy link
Contributor

I'm happy to merge here as soon as you are @traversaro :)

@traversaro
Copy link
Member Author

I'm happy to merge here as soon as you are @traversaro :)

I am finishing a local Windows build (that is basically just running it and skipping the failing packages at the moment). As soon as that is done, for me this is ready to merge!

@traversaro
Copy link
Member Author

traversaro commented Jan 6, 2025

Local build of Windows package (~580 packages) completed, the PR is ready for merge for me. I am just not familiar with RoboStack/robostack.github.io#42 to understand if this could be a problem post merge, but we could solve this also with following PRs.

@Tobias-Fischer Tobias-Fischer merged commit aa18162 into RoboStack:main Jan 6, 2025
1 of 6 checks passed
@Tobias-Fischer
Copy link
Contributor

Local build of Windows package (~580 packages) completed, the PR is ready for merge for me. I am just not familiar with RoboStack/robostack.github.io#42 to understand if this could be a problem post merge, but we could solve this also with following PRs.

I simplified it a little in vinca - let's see what happens :)

@EzraBrooks
Copy link

thanks so much for all your work on this!

@traversaro
Copy link
Member Author

@Tobias-Fischer it seems we need to update the token.

Pixi task (upload in default): anaconda -t $ANACONDA_API_TOKEN upload C:\bld\win-64\*.conda --force
Using Anaconda API: https://api.anaconda.org/
Error:  ('Authentication token has expired', 401)
Error: Process completed with exit code 1.

@Tobias-Fischer
Copy link
Contributor

All done - token updated and also resolved some issues that emerged after removing the unnecessary docker container.

@Tobias-Fischer
Copy link
Contributor

@traversaro - Windows builds just finished, thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants