-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild January 2025 - switch to rattler-build #229
Rebuild January 2025 - switch to rattler-build #229
Conversation
It was superseded by moveit/moveit2#2399 .
…in.patch The patch was integrated upstream in moveit/moveit2#2395 .
…eason is not added
Heavely based on RoboStack/ros-jazzy#5
I’d say let’s wait for @wolfv to take a look at the cirun.io issue and then also run the PRs on the native aarch runners to avoid all those annoying and time consuming cross compile issues. |
Yes, that would be ideal! |
osx-64 is failing with:
|
@traversaro that is a transient clobber error that @Tobias-Fischer already reported :/ sorry about that. I'll have to dig in to see where this fails tomorrow. |
Ah right, I even commented there! But I did not recognized it. Let's cross-link the issue: prefix-dev/rattler-build#1288 . |
Another strange problem is that somehow on Windows package that depend on yaml-cpp or console-bridge also copy as part of the compiled package, and then clearly those packages start coblerring with the same files from their depedencies, see:
|
I am happy with all platforms except for linux-aarch64 in a previous run (https://github.com/RoboStack/ros-humble/actions/runs/12622123371), let's see how linux-aarch64 is going in this run and then I think it's ready for merging. |
I'm happy to merge here as soon as you are @traversaro :) |
I am finishing a local Windows build (that is basically just running it and skipping the failing packages at the moment). As soon as that is done, for me this is ready to merge! |
Local build of Windows package (~580 packages) completed, the PR is ready for merge for me. I am just not familiar with RoboStack/robostack.github.io#42 to understand if this could be a problem post merge, but we could solve this also with following PRs. |
I simplified it a little in vinca - let's see what happens :) |
thanks so much for all your work on this! |
@Tobias-Fischer it seems we need to update the token.
|
All done - token updated and also resolved some issues that emerged after removing the unnecessary docker container. |
@traversaro - Windows builds just finished, thanks again :) |
Full rebuild on all platforms, heavily based on:
List of PRs and issues that will be fixed once this PR is merged:
ur_calibration
2.5.1 . As of this PR theur_calibration
is only available onlinux-64
, but that matches the existing behaviour, and Package request: ur_calibration>=2.2.13 #217 only asked for a version update.moveit-visual-tools
on all platformsament-cmake-vendor-package
on all platformsrosbag2-storage-mcap
on all platformsevent-camera-codecs
andevent-camera-renderer
on all platforms