This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Test PR of luacov-coveralls #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
suggested changes
Jan 16, 2020
| @@ -28,17 +28,16 @@ jobs: | |||
| run: | | |||
| luarocks install luafilesystem | |||
| luarocks install luacov | |||
| luarocks install luacov-coveralls --server=http://rocks.moonscript.org/dev | |||
| git clone https://github.com/alerque/luacov-coveralls.git --branch fix-actions-service-name | |||
There was a problem hiding this comment.
This close is correct, but Luarocks then procedes to use the URL in the spec to download what it wants! I posted a rockspec just for testing this that downloads from the right branch:
Suggested change
| git clone https://github.com/alerque/luacov-coveralls.git --branch fix-actions-service-name | |
| wget https://gist.githubusercontent.com/alerque/09ec33446e69f60243b80c28d4b44aec/raw/21574b22ef3c2511a578f74c193622d1fdff2bd2/luacov-coveralls-TEST-0.rockspec |
| @@ -28,17 +28,16 @@ jobs: | |||
| run: | | |||
| luarocks install luafilesystem | |||
| luarocks install luacov | |||
| luarocks install luacov-coveralls --server=http://rocks.moonscript.org/dev | |||
| git clone https://github.com/alerque/luacov-coveralls.git --branch fix-actions-service-name | |||
| luarocks install ./luacov-coveralls/rockspecs/luacov-coveralls-scm-0.rockspec | |||
There was a problem hiding this comment.
...and use the rockspec we just fetched:
Suggested change
| luarocks install ./luacov-coveralls/rockspecs/luacov-coveralls-scm-0.rockspec | |
| luarocks install ./luacov-coveralls-TEST-0.rockspec |
|
I think I've confirmed via another project that changes I proposed to work correctly. |
|
Cool, thanks for going through and fixing this! Going to close this PR then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is testing a PR to luacov-coveralls: moteus/luacov-coveralls#21
It should also allow us to drop the need to pass our repo token explicitly.