Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #114 (Support for EndroidQR v5) #115

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

Mattie112
Copy link
Contributor

The new version is using PHP ENUMs, added a check to make it compatible with v5.

Should also still work for v4 (and older)!

Tested with endroid/qr-code v4.8.5 and v5.0.2 with both versions I can generate a QR code.

            $qr_provider = new EndroidQrCodeProvider();
            $tfa = new TwoFactorAuth("xx", qrcodeprovider: $qr_provider);
            $qr = $tfa->getQRCodeImageAsDataUri("uid", $secret);

@willpower232 willpower232 merged commit ab93dd4 into RobThree:master Nov 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants