a bit of a clean up for regexes #146
Closed
+24
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Aug 13, 2020
| @@ -23,7 +23,7 @@ | |||
| final class Flag | |||
| { | |||
| /** | |||
| * within extent of same version patch flag is of the highest priority | |||
| * within extent of the same version "patch" flag is of the highest priority | |||
| * - stability flag, e.g. alpha, beta and etc. | ||
| * - stability numbers | ||
| */ | ||
| public const TAGGED_VERSION_MATCHER = '\s*(?<version>(?:\d+\.)*\d+)(?:-(?<flag>stable|beta|b|rc|alpha|a|patch|p)[._-]?(?<stability_numbers>(?:\d+\.)*\d+)?)?\s*'; |
There was a problem hiding this comment.
Is there any functional change in this patch?
There was a problem hiding this comment.
There is no functional change in this patch, just wanted it to be a bit more clean.
There was a problem hiding this comment.
I must say that I find the previous version cleaner/easier to follow :|
There was a problem hiding this comment.
okay, then lets close it. No worries.
Sorry for the noise
There was a problem hiding this comment.
Alright, thanks for the effort anyway!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I recently saw that comment laminas/automatic-releases#25 (comment) decided to clean class a little bit.
If I do remember correctly when
TAGGED_VERSION_MATCHERregexp was compiled semver did not offer any regex recipes. So later on when they did offer one I though may be we could ditch the we have in favor of recommended.Long story short — it does not quite what package needs 🤔
Here is the list mentioned in the comment with our regexp, do you think I should improve regular expression to better match that list ?