Make append O(N)

[saik0]

Continuation on #131

Summary

• Append is currently O(N logN) as it must binary search through containers on each insert. Inserting into an array container is also logN.
• This converts append operation to O(N) by adding a crate public push_unchecked methods that should only be called once it's been verified that the value >= max. Eliminating both of the logN lookups

Before

After

[saik0]

Mistakenly opened this as a PR, rather than a draft.

Treemap append needs tests that spans across bitmaps

[Kerollmops]

Mistakenly opened this as a PR, rather than a draft.

Fixed that for you 😄 (top right, just below the reviewers).

[saik0]

Mistakenly opened this as a PR, rather than a draft.

Fixed that for you 😄 (top right, just below the reviewers).

I don't believe I can change that as a non-member

[Kerollmops]

I don't believe I can change that as a non-member

I just checked on a non-owned repo and yes you can, it is just that the link is not present as it is now a Draft, but I am pretty sure you can 😃

[saik0]

These methods are not unsafe their are just "dangerous" 😅

The unsafe keyword has a very precise meaning:

Code or interfaces whose memory safety cannot be verified by the type system.

push_unchecked does not violate memory safety, though care does need to be taken when calling it, which is why i suffixed it with unchecked.

What would you think about adding some debug_assert to the bodies to check the invariants in debug builds?

[saik0]

Also it's pub(crate) so end users can't call it. Us contributors are the only ones who need to be careful.

[Kerollmops]

Ok, it seems like you are right, for dangerous internal functions we can keep them safe. Use this comment for #127 too, don't declare them as unsafe!

[saik0]

I've added debug assertions and clear docs about the validity guarantees.

[Kerollmops]

Thank you very much for your work!
bors merge

[bors]

Build succeeded:

• ci (stable)