Merge pull request #1108 from morganmspencer/patch-1

Account for multiline comments in markdown content
RoadieHQ · Sep 11, 2023 · 66999d2 · 66999d2
2 parents 394ac0f + 8672138
commit 66999d2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/witty-garlics-tap.md b/.changeset/witty-garlics-tap.md
@@ -0,0 +1,6 @@
+---
+'@roadiehq/backstage-plugin-github-insights': patch
+---
+
+The `MarkdownContent` component currently removes only single line comments if `preserveHtmlComments` is not set.
+This change accounts for single line and multiline HTML comments
diff --git a/...ckstage-plugin-github-insights/src/components/Widgets/MarkdownContent/MarkdownContent.tsx b/...ckstage-plugin-github-insights/src/components/Widgets/MarkdownContent/MarkdownContent.tsx
@@ -86,7 +86,7 @@ const GithubFileContent = (props: MarkdownContentProps) => {
 
   let content = value.content;
   if (!preserveHtmlComments) {
-    content = content.replace(/<!--.*?-->/g, '');
+    content = content.replace(/<!--(.|\n)*?-->/g, '');
   }
 
   return (