Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flurl to v4.0.2 #171

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Upgrade Flurl to v4.0.2 #171

merged 2 commits into from
Aug 25, 2024

Conversation

Riges
Copy link
Owner

@Riges Riges commented Aug 25, 2024

Summary:
This pull request upgrades the Flurl library used in the project and includes necessary adjustments to ensure compatibility with the new version.
Because Flurl v4 move to System.text.Json we need to change here the serializer.

Changes:

  1. Flurl Library Upgrade:

    • Updated the Flurl library to the latest version.
    • Modified the code to accommodate breaking changes and new features introduced in the updated Flurl library.
  2. Code Adjustments:

    • Updated API calls to use the new Flurl syntax and methods.
    • Ensured that all HTTP requests and responses are handled correctly with the actual Netatmo API.
  3. Testing:

    • Verified that all existing unit tests pass with the upgraded Flurl library.
    • Added new tests where necessary to cover changes in the HTTP request/response handling.

Files Modified:

  • tests/TestApp/Program.cs
  • tests/Netatmo.Tests/EnergyClientTest.cs

Notes:

  • This upgrade aims to leverage the improvements and bug fixes in the latest version of Flurl.
  • Ensure that the application is thoroughly tested to confirm that the upgrade does not introduce any regressions.

Breaking change of Flurl v4 on usage NewtonSoft.Json to System.Text.Json
@Riges Riges merged commit 95cba90 into master Aug 25, 2024
6 checks passed
@Riges Riges deleted the upgrade_flurl branch August 25, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant