fix: browser.storage should not include unknown keys in the result
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in the [documentation](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/StorageArea/get), when the key is not present in the storage, it should be completely missing from the `.get()` result as well. The current mock implementation was returning the key in the result with `undefined` value. Also the lastly added session storage mock was sharing data with local storage.
|
@MikkCZ thank you so much for your contributions! ❤️ Please run |
|
Oh I see. I will then need to update all PRs, once they are rebased on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the documentation, when the key is not present in the storage, it should be completely missing from the
.get()result as well. The current mock implementation was returning the key in the result withundefinedvalue.Also the lastly added session storage mock was sharing data with local storage.