-
Notifications
You must be signed in to change notification settings - Fork 124
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use more GNU/Autotools idiomatic names and methods
We're extending GNU/Autotools with our own macros. This is allowed and even expected, but there are certainly more and less idiomatic ways to do so. This normalizes all our extended bits to be as idiomatic as possible to make auditing easier. * Filename prefixes are more representative of their source: especially we are not hijacking the ax_ prefix which usually references something from autotools-archive that could be compared with a known source. All files starting with ax_ could be removed from the repository and the project still built provided autotools-archive was available on the host system. We're still vendoring them because it is not as broadly available as autotools, but these bits don't need to be audited as part of this project. I used que_ as a prefix to make them easy to find and because I've authored them and share identical extensions across a number of other projects. The configure macros and makefile extensions have matching prefixes so they sort together. * The AMINCLUDE system is leveraged instead of hand rolling includes. This is actually probably slightly *harder* to grok, but again the macros used are standardized in autoconf-archive.) I think the more idiomatic usage has the payoff of not sounding any more alarms than we need to. It also has the advantage of a single place to enable/disable a component of the build instead of needing to comment out both the configure macro(s) and makefile include(s) separately.
- Loading branch information
Showing
13 changed files
with
51 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,5 +16,6 @@ completions/vcsh | |
config.log | ||
config.status | ||
configure | ||
aminclude.am | ||
/vcsh | ||
vcsh-* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
AC_DEFUN([QUE_DIST_CHECKSUMS], [ | ||
QUE_PROGVAR([sha256sum]) | ||
QUE_PROGVAR([tee]) | ||
QUE_TRANSFORM_PACKAGE_NAME | ||
AC_REQUIRE([AX_AM_MACROS]) | ||
AX_ADD_AM_MACRO([dnl | ||
$(cat build-aux/que_dist_checksums.mk) | ||
])dnl | ||
]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
AC_DEFUN([QUE_GIT_VERSION], [ | ||
AC_PROG_AWK | ||
AC_PROG_GREP | ||
QUE_PROGVAR([cmp]) | ||
QUE_TRANSFORM_PACKAGE_NAME | ||
AC_REQUIRE([AX_AM_MACROS]) | ||
AX_ADD_AM_MACRO([dnl | ||
$(cat build-aux/que_git_version.mk) | ||
])dnl | ||
]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters