Add text in default language to feedbackSurveyCompleted callback
#4625
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
vegaro
force-pushed
the
cc-224-send-english-text-in-survey-option-callback
branch
from
ef87340 to
9e4df29
Compare
vegaro
force-pushed
the
cc-224-send-english-text-in-survey-option-callback
branch
from
9e4df29 to
6f14273
Compare
1 build decreased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬇️ -190.0 kB |
| Code Signature | ⬇️ -11.5 kB |
| DYLD.Exports | ⬇️ -9.0 kB |
| 🗑 RevenueCatUI.PurchaseHistoryViewModel | ⬇️ -6.2 kB |
| Strings.Unmapped | ⬇️ -1.7 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
vegaro
commented
Jan 21, 2025
| case feedbackSurveyCompleted(_ feedbackSurveyOptionId: String) | ||
| /// An option of the feedback survey has been selected | ||
| /// - Parameter option: The ``CustomerCenterConfigData.HelpPath.FeedbackSurvey.Option`` that was selected | ||
| case feedbackSurveyCompletedWithOption(_ option: CustomerCenterConfigData.HelpPath.FeedbackSurvey.Option) |
There was a problem hiding this comment.
I ended up changing the name of the case because I coudln't find a way where the Swift compiler wouldn't get confused.
I tried adding another parameter and keeping the name and got this:
I also tried returning the whole option (keeping one parameter only) and got this:
I am also concerned because Switch must be exhaustive, meaning this is a breaking change:
vegaro
changed the title
defaultLanguageText to feedbackSurveyCompleted callbackfeedbackSurveyCompleted callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes we did to the localization UI, this callback is kinda broken since the ids are auto-generated, and mean nothing to the developer.
After this PR we'll be sending the English translation of the option as well so it's easier to understand what each option represent. It requires backend changes to send the English/default language translation to the callback as well.