Fixes reloading paywall images after they've been scrolled off screen #4423
+73
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. This showed up when testing the sticky footer component, but doesn't have anything to do with sticky footers. As you can see in the before video, the image keeps reloading, making it difficult for the user to scroll up.
This is fixed by the
ImageLoaderchecking whether it has received a new URL before actually resetting its published state and loading an image. If it receives the same URL twice, it will ignore it the second time, keeping its published state the same.Before
Schermopname.2024-10-29.om.16.15.30.mov
After
Schermopname.2024-10-29.om.16.10.03.mov