Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes reloading paywall images after they've been scrolled off screen #4423

Open
wants to merge 4 commits into
base: sticky-footer-component-4
Choose a base branch
from

Conversation

JayShortway
Copy link
Member

As the title says. This showed up when testing the sticky footer component, but doesn't have anything to do with sticky footers. As you can see in the before video, the image keeps reloading, making it difficult for the user to scroll up.

This is fixed by the ImageLoader checking whether it has received a new URL before actually resetting its published state and loading an image. If it receives the same URL twice, it will ignore it the second time, keeping its published state the same.

Before

Schermopname.2024-10-29.om.16.15.30.mov

After

Schermopname.2024-10-29.om.16.10.03.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant