[EXTERNAL] Cocoapods support for privacy manifest (#3772) via @sdurban #3775
Conversation
### Motivation The library already includes Privacy.xcprivacy in SPM, but when used with CocoaPods (mandatory in Flutter), these files are not exported as the podspec does not include that file as a resource bundle. ### Description Listing the PrivacyInfo.xcprivacy file inside the resource_bundles specification in the podspec allows to distribute the file correctly. Ref. CocoaPods/CocoaPods#10325 (comment) This GitHub issue contains the entire discussion on how to add these xcprivacy files and is referenced in multiple places; many libraries already follow this approach: https://github.com/firebase/firebase-ios-sdk/blob/main/FirebaseCrashlytics.podspec SDWebImage/SDWebImage#3649 flutter/packages#5846 Baseflow/flutter-permission-handler#1291 Baseflow/flutter-geolocator#1462
|
For context for reviewers, this is coming from #3772, and I tested the changes locally and verified that the privacy manifest gets picked up correctly after adding |
| @@ -31,5 +31,5 @@ Pod::Spec.new do |s| | |||
| s.source_files = 'Sources/**/*.swift' | |||
| s.exclude_files = 'Sources/LocalReceiptParsing/ReceiptParser-only-files/**' | |||
|
|
|||
|
|
|||
| s.resource_bundles = {'RevenueCat' => ['Sources/PrivacyInfo.xcprivacy']} | |||
There was a problem hiding this comment.
Hmm I was wondering if we also need this for RevenueCatUI but I think it shouldn't be needed, since RevenueCat is also a dependency for RevenueCatUI right?
There was a problem hiding this comment.
Yeah, that's my understanding. Having it only in RevenueCat would also match our SPM setup.
In any case even if we did need to add it we could do it as a separate PR, it doesn't really take value away from merging this one
|
|
Motivation
The library already includes Privacy.xcprivacy in SPM, but when used with CocoaPods (mandatory in Flutter), these files are not exported as the podspec does not include that file as a resource bundle.
Description
Listing the PrivacyInfo.xcprivacy file inside the resource_bundles specification in the podspec allows to distribute the file correctly. Ref.
CocoaPods/CocoaPods#10325 (comment)
This GitHub issue contains the entire discussion on how to add these xcprivacy files and is referenced in multiple places; many libraries already follow this approach:
https://github.com/firebase/firebase-ios-sdk/blob/main/FirebaseCrashlytics.podspec SDWebImage/SDWebImage#3649 flutter/packages#5846
Baseflow/flutter-permission-handler#1291 Baseflow/flutter-geolocator#1462