Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paywalls V2] Adds ImageComponentView tests #2013

Draft
wants to merge 127 commits into
base: main
Choose a base branch
from
Draft

[Paywalls V2] Adds ImageComponentView tests #2013

wants to merge 127 commits into from

Conversation

JayShortway
Copy link
Member

Description

Still a draft, because tests are still failing, partly as some changes to existing code are needed to make it testable.

@JayShortway
Adds PaywallComponentsData to Offering, and has PaywallViewModel use …
15ee579 
…that.
@JayShortway
Renames PaywallDataValidationTest to LegacyPaywallDataValidationTest.
97a6d2a
@JayShortway
LoadingPaywall calls toLegacyPaywallState.
f039302
@JayShortway
OfferingParser parses paywall_components.
9153fc0
@JayShortway
Adds Paywalls V2 support to PaywallsTester.
0a07fd5
@JayShortway
Adds missing circle MaskShape.
8616a26
@JayShortway
LoadedPaywallComponents will always fill the maximum available size.
bbe72eb
@JayShortway
ImageUrls width and height are optional.
27837e2
@JayShortway
Merge branch 'main' into pw2-offerings-data
0e60bd3
@JayShortway
Merge branch 'pw2-offerings-data' into pw2-tester
3d6fd64
@JayShortway
Reverts Constants.
da94c38
@JayShortway
Merge branch 'pw2-tester' into pw2-various-fixes
f849520
@JayShortway
Fixes lint.
b669421
@JayShortway
Merge branch 'pw2-offerings-data' into pw2-tester
07cfc1c
@JayShortway
Merge branch 'pw2-tester' into pw2-various-fixes
442b479
@JayShortway
StackComponentView changes background color when the theme changes.
49e604a
@JayShortway
Adds a failing test to StackComponentViewTests.
2b5574d
@JayShortway
Adds 2 previews.
7271506
@JayShortway
Ensures MDParagraph uses the correct fontSize.
dc58101
@JayShortway
Merge branch 'main' into pw2-offerings-data
4f4bc41
@JayShortway
Merge branch 'pw2-offerings-data' into pw2-tester
c7657da
@JayShortway
Merge branch 'pw2-tester' into pw2-various-fixes
4b54f33
@JayShortway
Merge branch 'pw2-various-fixes' into pw2-fix-fontsize
831854a
@JayShortway
Adds another failing test to StackComponentViewTests.
7bc2786
@JayShortway
Removing some redundant parameters.
38401ed
@JayShortway
Fixes the border test.
65affb8
@JayShortway
Fixes the shadow test.
453b5cf
@JayShortway
Some cleanup.
4c189ee
@JayShortway
Merge branch 'pw2-fix-fontsize' into pw2-stack-tests
7952c6a
@JayShortway
Merge branch 'main' into pw2-tester
a342ed8
@JayShortway
Merge branch 'pw2-nonemptymap' into pw2-validate-loading-phase
b5a1364 
# Conflicts:
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/LoadedPaywallComponents.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentViewTests.kt
@JayShortway
Fixes some compiler errors.
86eff62
@JayShortway
Fixes some compiler errors.
55b8781
@JayShortway
Merge branch 'pw2-stack-component-state' into pw2-minor-cleanup
1d8b505
@JayShortway
Merge branch 'pw2-minor-cleanup' into pw2-localization-state
495b996 
# Conflicts:
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentViewWindowTests.kt
@JayShortway
Merge branch 'pw2-localization-state' into pw2-nonemptymap
18470a9 
# Conflicts:
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentViewWindowTests.kt
@JayShortway
Merge branch 'pw2-nonemptymap' into pw2-validate-loading-phase
1aed5d9
@JayShortway
Adds PresentedImagePartial.
db56990
@JayShortway
Merge branch 'main' into pw2-localization-state
444aec5 
# Conflicts:
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/LoadedPaywallComponents.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/button/ButtonComponentView.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentView.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/style/StyleFactory.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/style/TextComponentStyle.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentView.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/button/ButtonComponentViewTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentViewTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentViewWindowTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/style/StyleFactoryTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentViewTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentViewWindowTests.kt
@JayShortway
Merge branch 'pw2-localization-state' into pw2-nonemptymap
b230d9e
@JayShortway
Merge branch 'pw2-nonemptymap' into pw2-validate-loading-phase
6066ec6
@JayShortway
Merge branch 'main' into pw2-nonemptymap
5f703c3 
# Conflicts:
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/LoadedPaywallComponents.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/LocalizedTextPartial.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/button/ButtonComponentView.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/ktx/Localization.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentView.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/style/StyleFactory.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/style/TextComponentStyle.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentState.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentView.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/helpers/Result.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/BuildPresentedPartialTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/LocalizedTextPartialTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/ToPresentedOverridesTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/button/ButtonComponentViewTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentViewTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentViewWindowTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/style/StyleFactoryTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentViewTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentViewWindowTests.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/helpers/FakePaywallState.kt
@JayShortway
Merge branch 'pw2-nonemptymap' into pw2-validate-loading-phase
2bb0b1d
@JayShortway
Merge branch 'pw2-validate-loading-phase' into pw2-image-state
386e503
@JayShortway
Fixes tests.
ab86ede
@JayShortway
Merge branch 'pw2-nonemptymap' into pw2-validate-loading-phase
7fb11a9
@JayShortway
Merge branch 'pw2-validate-loading-phase' into pw2-image-state
5ee0df0
@JayShortway
Adds FitMode.toContentScale(), MaskShape.toShape() and imageForAllLoc…
4005bc5 
…ales().
@JayShortway
Merge branch 'main' into pw2-validate-loading-phase
80a2917 
# Conflicts:
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/LoadedPaywallComponents.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/button/ButtonComponentView.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/stack/StackComponentView.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/components/text/TextComponentView.kt
#	ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/helpers/NonEmptyMap.kt
#	ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/helpers/ResultTests.kt
@JayShortway
Adds ImageComponentState.
ffaea92
@JayShortway
Adds (failing) ImageComponentView tests.
bec3062
@JayShortway
Merge branch 'main' into pw2-validate-loading-phase
7755855
@JayShortway
Merge branch 'pw2-validate-loading-phase' into pw2-image-state
f8cdcee
@JayShortway
Merge branch 'pw2-image-state' into pw2-image-tests
a3c396c
@JayShortway JayShortway self-assigned this Dec 27, 2024
@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Dec 30, 2024

📸 Snapshot Test

Some snapshots failed to render

Name Added Removed Modified Unchanged Errored Approval
TestPurchasesUIAndroidCompatibility
com.revenuecat.testpurchasesuiandroidcompatibility		 0 0 1 105 23 ⏳ Needs approval

🛸 Powered by Emerge Tools

Base automatically changed from pw2-image-state to main January 2, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JayShortway JayShortway

Labels
feat:PaywallV2 pr:other pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JayShortway