Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paywalls V2] Root background changes depending on the theme #1983

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

[Paywalls V2] Root background changes depending on the theme #1983

wants to merge 35 commits into from

Conversation

JayShortway
Copy link
Member

@JayShortway JayShortway commented Dec 13, 2024 •
edited
Loading

As the title says. Still a draft, because it only adds failing tests. Need to actually fix it.
Also:

  • Make sure that image color overlays change with the theme too.

@JayShortway
Adds PaywallComponentsData to Offering, and has PaywallViewModel use …
15ee579 
…that.
@JayShortway
Renames PaywallDataValidationTest to LegacyPaywallDataValidationTest.
97a6d2a
@JayShortway
LoadingPaywall calls toLegacyPaywallState.
f039302
@JayShortway
OfferingParser parses paywall_components.
9153fc0
@JayShortway
Adds Paywalls V2 support to PaywallsTester.
0a07fd5
@JayShortway
Adds missing circle MaskShape.
8616a26
@JayShortway
LoadedPaywallComponents will always fill the maximum available size.
bbe72eb
@JayShortway
ImageUrls width and height are optional.
27837e2
@JayShortway
Merge branch 'main' into pw2-offerings-data
0e60bd3
@JayShortway
Merge branch 'pw2-offerings-data' into pw2-tester
3d6fd64
@JayShortway
Reverts Constants.
da94c38
@JayShortway
Merge branch 'pw2-tester' into pw2-various-fixes
f849520
@JayShortway
Fixes lint.
b669421
@JayShortway
Merge branch 'pw2-offerings-data' into pw2-tester
07cfc1c
@JayShortway
Merge branch 'pw2-tester' into pw2-various-fixes
442b479
@JayShortway
StackComponentView changes background color when the theme changes.
49e604a
@JayShortway
Adds a failing test to StackComponentViewTests.
2b5574d
@JayShortway
Adds 2 previews.
7271506
@JayShortway
Ensures MDParagraph uses the correct fontSize.
dc58101
@JayShortway
Merge branch 'main' into pw2-offerings-data
4f4bc41
@JayShortway
Merge branch 'pw2-offerings-data' into pw2-tester
c7657da
@JayShortway
Merge branch 'pw2-tester' into pw2-various-fixes
4b54f33
@JayShortway
Merge branch 'pw2-various-fixes' into pw2-fix-fontsize
831854a
@JayShortway
Adds another failing test to StackComponentViewTests.
7bc2786
@JayShortway
Removing some redundant parameters.
38401ed
@JayShortway
Fixes the border test.
65affb8
@JayShortway
Fixes the shadow test.
453b5cf
@JayShortway
Some cleanup.
4c189ee
@JayShortway
Merge branch 'pw2-fix-fontsize' into pw2-stack-tests
7952c6a
@JayShortway
Merge branch 'main' into pw2-tester
a342ed8
@JayShortway JayShortway self-assigned this Dec 13, 2024
@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Dec 13, 2024

📸 Snapshot Test

52 modified, 8 added, 3 removed, 61 unchanged

Name Added Removed Modified Unchanged Errored Approval
TestPurchasesUIAndroidCompatibility
com.revenuecat.testpurchasesuiandroidcompatibility		 8 3 52 61 0 ⏳ Needs approval

🛸 Powered by Emerge Tools

Base automatically changed from pw2-stack-tests to main December 17, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JayShortway JayShortway

Labels
feat:PaywallV2 pr:other pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JayShortway