wolf4sdl: game data (Spear of Destiny) #3445
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Wolfenstein 3D docs we are instructed to rename three files from the Spear of Destiny expansion from extension
.sod
to.sd1
. (Presumablybecause the source files are available in both formsand so no one way is going to work in the scripts without some renaming.)(Edit):
It seems that Steam provides the games with
.sd1
files, while original installation media ("Spear of Destiny: Super CD Pack") uses.sod
.Although we can make it work with both names.
(Renaming to
.sd1
broke compatibility with RetroPie-Extra's ecwolf package, but the same file runs fine when named.sod
.)wolf4sdl can run it with either name but the command is different either way. With
.sd1
it needs to have the--mission 1
option, and with.sod
it needs to NOT have that option.This change checks for all three versions (sod, sd1, and the shareware sdm) before downloading shareware data, and uses the correct command for each one.
(Original):
But then the install script still checks for the old .sod file when determining whether to download the shareware version. So even if we have the registered version files, if we rename them as instructed then the shareware will still be downloaded, because the filenames don't match what is being checked for.It still works (I'll change this from "bug" to "QOL"), it just always downloads the shareware, whether it is needed or not.This should fix it so it will search for the correct file. I also added a function that should automatically rename the .sod files so we don't have to do it manually.