forked from recalbox/recalbox-manager
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please merge this new and improved, working version of RetroPie-Manager into RetroPie. #3
Open
hifihedgehog
wants to merge
21
commits into
RetroPie:retropie
Choose a base branch
from
NicholasBerryman:retropie
base: retropie
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Ubuntu 20.04
hifihedgehog
changed the title
Please delete bin, include, and share folders to make platform independent builds easier
Please integrate this newer, working version of RetroPie-Manager into RetroPie.
Mar 10, 2021
hifihedgehog
changed the title
Please integrate this newer, working version of RetroPie-Manager into RetroPie.
Please merge this newer, working version of RetroPie-Manager into RetroPie.
Mar 10, 2021
Please remove this directory to make this repo buildable across all platforms. This is created by your system for its unique architecture and configuration for its virtual environment. Anyone who uses this repo like myself has to be manually delete this before they can build if their build environment is different. Otherwise, make install will fail, which is why I incorrectly resorted to using global Python before this. (As a side note, I was wrong by using global Python in the makefile. Global Python does not work properly when called by the running process which causes the monitoring page to not work. This is why running Python from the local bin folder in the makefile after initially creating the virtual environment is the correct approach, which you had fixed.) You will notice that is why RetroPie/RetroPie-Manager does not have the share, bin, and include folders.
Please remove this directory to make this repo buildable across all platforms. This is created by your system for its unique architecture and configuration for its virtual environment. Anyone who uses this repo like myself has to be manually delete this before they can build if their build environment is different. Otherwise, make install will fail, which is why I incorrectly resorted to using global Python before this. (As a side note, I was wrong by using global Python in the makefile. Global Python does not work properly when called by the running process which causes the monitoring page to not work. This is why running Python from the local bin folder in the makefile after initially creating the virtual environment is the correct approach, which you had fixed.) You will notice that is why RetroPie/RetroPie-Manager does not have the share, bin, and include folders.
Please remove this directory to make this repo buildable across all platforms. This is created by your system for its unique architecture and configuration for its virtual environment. Anyone who uses this repo like myself has to manually delete this before they can build if their build environment is different from yours. Otherwise, make install will fail, which is why I incorrectly resorted to using global Python beforehand. (As a side note, as you had noticed, I was wrong to use global Python in the makefile like I did. Global Python does not work properly when called by the running process which causes the monitoring page to not work. This is why running Python from the local bin folder in the makefile after initially creating the virtual environment is the correct approach, which you had fixed.) You will notice that is why RetroPie/RetroPie-Manager does not have the share, bin, lib, and include folders.
Delete share/python-wheels directory
Delete bin directory
Delete lib/python2.7 directory
Delete include directory
If this is integrated into the main branch for RetroPie-Manager (https://github.com/RetroPie/RetroPie-Manager), we will want to match this pull request (RetroPie@ae65d7e) that updates this URL from the old abandoned repo to RetroPie's repo.
hifihedgehog
commented
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also include these changes.
hifihedgehog
changed the title
Please merge this newer, working version of RetroPie-Manager into RetroPie.
Please merge this new and improved, working version of RetroPie-Manager into RetroPie.
Mar 10, 2021
Fix repository URL in skeleton.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to share this working fork works which, among other things, restores x86 and x86-64 compatibility on Ubuntu 20.04 LTS, as well as bringing a slew of improvements to the table. First, a big show of thanks to @NicholasBarryman for doing all the work he did to get this excellent web interface working again! He updated the monitoring page to provide live, actively updated system information using AJAX and JSON, so things like processor core utilization and memory usage can now be viewed instantly without ever refreshing the page. He also bumped up the upload file size limit for ROM files from 256MB to 10GB which is especially useful for disc-based systems like PlayStation, Dreamcast, GameCube, PS2 or Wii.