Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for registrar component testing #20

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

teles-mami
Copy link

The current implementation did not predict the possibility of an external registrar component (separate from proxy). This pull request adds the modification to the SipPhone and SipStack in order to create phones aimed at registering on this external registrar.

TELES AG uses this alteration in testing the registrar component, which is separate from the proxy. The examples on how to test the REGISTER request behavior against the registrar component for error handling and similar cases are included in the test suite.

We are open to questions and suggestions on how to differently handle REGISTER testing.

Best regards,
Mario Milas

teles-mami and others added 7 commits January 9, 2018 08:21
The current implementation did not predict the possibility of an external registrar component (separate from proxy). This commit adds the modification to the SipPhone and SipStack in order to create phones aimed at registering on this external registrar.
Also added the possibility of header overrides within the REGISTER request in order to stress-test the registrar processing.
@gsaslis
Copy link
Contributor

gsaslis commented Jan 9, 2018

Hi @teles-mami,

Thanks for the PR ❤️ - appreciate you taking the time to contribute this!!

Could you please take a look at our Open Source Playbook and then proceed with signing our CLA, so we can then move forward with reviewing this?

Thanks in advance!
Yorgos

@teles-mami
Copy link
Author

Hi,

I've read the playbook and signed the CLA.

However, I'm not sure if for this project some guidelines can follow, but I've tried to be as closely compliant with them as possible. For further commits I will be opening issues to reference to. As per the playbook, should I squash the pull request?

Also, is this pull request now eligible for review?

Best regard,
Mario

@gsaslis
Copy link
Contributor

gsaslis commented Jan 24, 2018

Thanks a lot @teles-mami and apologies for the late reply here!

Please don't squash just yet.
@jaimecasero could you please take a look at this one ?

@gsaslis gsaslis requested review from a team and removed request for jaimecasero February 9, 2018 11:07
@jaimecasero
Copy link
Contributor

PR looks ok to me. I need to check testsuite results to merge...

@gsaslis
Copy link
Contributor

gsaslis commented Feb 27, 2018

@jaimecasero any luck with the testsuite results here?

@teles-mami
Copy link
Author

Hi guys!

Sorry for the late reaction.

Any news on the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants