Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix critical vulnerabilities with dependencies #169

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ohorbachevskyi
Copy link
Contributor

What/Why/How?

Reference

https://github.com/Redocly/openapi-sampler/security/dependabot/17
https://github.com/Redocly/openapi-sampler/security/dependabot/42
https://github.com/Redocly/openapi-sampler/security/dependabot/47

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@ohorbachevskyi ohorbachevskyi requested a review from a team as a code owner August 30, 2024 12:22
Copy link
Contributor

@AlexVarchuk AlexVarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure all works fine with new updated version. Thanks

@ohorbachevskyi
Copy link
Contributor Author

ohorbachevskyi commented Aug 30, 2024

make sure all works fine with new updated version. Thanks

@AlexVarchuk Yes, it's dev dependencies upgrade, so I checked package scripts with gulp, they work as previously.

@ohorbachevskyi ohorbachevskyi added the dependencies Pull requests that update a dependency file label Aug 30, 2024
@ohorbachevskyi ohorbachevskyi merged commit aada8f1 into main Aug 30, 2024
2 checks passed
@adamaltman adamaltman deleted the chore/critical-vulnerabilities-deps branch August 30, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants