Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't eager load code on boot #106

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Don't eager load code on boot #106

merged 1 commit into from
Feb 4, 2019

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Feb 4, 2019

@mkanoor
Copy link
Contributor Author

mkanoor commented Feb 4, 2019

@gmcculloug @syncrou
Please review

@gmcculloug gmcculloug added the bug Something isn't working label Feb 4, 2019
@gmcculloug gmcculloug self-assigned this Feb 4, 2019
gmcculloug
gmcculloug approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

syncrou
syncrou approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - I'm going to add an issue for the common gem as these types of changes will be needed in all the services.

@syncrou syncrou merged commit 7425606 into RedHatInsights:master Feb 4, 2019
@syncrou
Copy link
Contributor

syncrou commented Feb 4, 2019

Issue in Common Gem for reference RedHatInsights/insights-api-common-rails#32

@bzwei bzwei mentioned this pull request Mar 12, 2019
Merged
gmcculloug pushed a commit to gmcculloug/catalog-api that referenced this pull request Nov 8, 2019
@martinpovolny
Merge pull request RedHatInsights#106 from Hyperkid123/upgrade-js-client
27ffcd9 
Update api client to match new routing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syncrou syncrou syncrou approved these changes

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@gmcculloug gmcculloug

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkanoor @syncrou @gmcculloug