Added heroku integration in readme #222
Conversation
| "name": "ROSE", | ||
| "description": "ROSE project car race game.", | ||
| "repository": "https://github.com/RedHat-Israel/ROSE", | ||
| "keywords": ["race", "game", "python"] |
There was a problem hiding this comment.
This should also describe:
- The server is started by running the
rose-serverscript - Port 8880 should be open to receive web clients
- Port 8888 should be open to receive rose-client(s)
See the updated issue for more details.
There was a problem hiding this comment.
Indeed, tried the button now from your fork https://github.com/mayukh18/ROSE/ => https://cben-rose-test.herokuapp.com, says "Application Error", heroku logs show:
2017-10-21T17:31:29.442324+00:00 heroku[router]: at=error code=H14 desc="No web processes running" method=GET path="/" host=cben-rose-test.herokuapp.com request_id=68b48dde-386d-4756-a4bd-a5901ea49fe5 fwd="141.226.169.57" dyno= connect= service= status=503 bytes= protocol=https
https://cben-rose-test.herokuapp.com:8880/ doesn't work either, connection refused.
-
I don't see anything in https://devcenter.heroku.com/articles/app-json-schema or elsewhere about specifying what port server internally listens on; we have to respect PORT env var that heroku provides.
-
On the outside, heroku router only listens on http[s] :80 and :443. That's fine for user interface, maybe will need to document that :8880 is not needed with heroku.
-
The nastier implication is you can't have 2nd outside port for rose-client. The client will have to connect on 80/443, and will need another mechanism for server to differentiate connection type (URL path? content-type? user-agent (meh)? custom header?).
There was a problem hiding this comment.
Yes I too didn't find any documentation related to servers and ports in https://devcenter.heroku.com/articles/app-json-schema and related articles. Second thing which I know is true is that heroku pre-assigns $PORT. What we need is a Procfile
| "description": "ROSE project car race game.", | ||
| "repository": "https://github.com/RedHat-Israel/ROSE", | ||
| "keywords": ["race", "game", "python"] | ||
| } |
|
Without a way to open a port for the client, Heroku is useless for us unless we redesign the way the client communicates with the server. I think we should stop this effort for now, and try OpenShift, it may be more flexible. |
|
Yes without a configurable port it can't be used properly. |
PR for #187