fix: Add SEO Page Title for 2 pages #7326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajitzero
changed the title
ajitzero
force-pushed
the
fix/odt-page-title
branch
from
6d5e570 to
ceaddb8
Compare
jakovljevic-mladen
requested changes
Dec 21, 2023
| @@ -1 +1,2 @@ | |||
| <h1 class="no-toc">Team</h1> | |||
There was a problem hiding this comment.
I think this heading is not needed. The reason for this is that the heading is still visible in the top header:
Please revert this one.
| @@ -110,7 +110,7 @@ | |||
| "github": "https://github.com/mattpodwysocki", | |||
| "picture": "https://avatars0.githubusercontent.com/u/49051", | |||
| "twitter": "https://twitter.com/mattpodwysocki", | |||
| "group": "Alumn" | |||
| "group": "Alumni" | |||
There was a problem hiding this comment.
As a non-native English speaker, I hope this one is right 🙂 I don't really know. Maybe @benlesh can help?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
h1tag of a page in this component.h1tag was placed within the component for the page and not in the HTML file itself. Moved it into the correct file now.h1tag. Added this now.Related issue (if exists):
None
Screenshot of fix:
#linkI suggest squash-committing this since I edited the commit messages via GitHub UI and will not pass commit-lint.Fixed commit messages.