Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pull_request_template.md #23

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Create pull_request_template.md #23

merged 2 commits into from
Apr 22, 2024

Conversation

ashleemboyer
Copy link
Member

🔗 Links

🗒️ What & Why

  • Adds a new file (.github/PULL_REQUEST_TEMPLATE/pull_request_template.md) according to the guide linked in the issue this PR resolves

🧪 Test Steps

  • Read the template as Markdown (since there are comments)
  • Read the template as rendered text (can be done in the GitHub UI)
  • Make sure everything makes sense

@ashleemboyer ashleemboyer added function: engineering Good for developing/practicing engineering skills. type: docs Additions, fixes, or improvements to documentation. Ex: code comments, READMEs, wiki pages. type: chore Small miscellaneous changes. Ex: upgrade dependencies, fix typo. labels Apr 22, 2024
@ashleemboyer ashleemboyer self-assigned this Apr 22, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 10:03pm

quinnmcphail
quinnmcphail approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@quinnmcphail quinnmcphail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ashleemboyer ashleemboyer merged commit e457576 into main Apr 22, 2024
4 checks passed
@ashleemboyer ashleemboyer deleted the amb/add-pr-template branch April 22, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnmcphail quinnmcphail quinnmcphail approved these changes

@ejmudrak ejmudrak Awaiting requested review from ejmudrak ejmudrak is a code owner

Assignees

@ashleemboyer ashleemboyer

Labels
function: engineering Good for developing/practicing engineering skills. type: chore Small miscellaneous changes. Ex: upgrade dependencies, fix typo. type: docs Additions, fixes, or improvements to documentation. Ex: code comments, READMEs, wiki pages.
Projects
None yet
Milestone
MVP #1 - Leave Meetup.com
Development

Successfully merging this pull request may close these issues.

Add PR template
2 participants
@ashleemboyer @quinnmcphail