Skip to content

Commit

Permalink
Made header image responsive. Fixes #5 (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
pirate-matt authored Apr 20, 2024
1 parent 9627eb9 commit e045510
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 12 deletions.
23 changes: 13 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,18 @@ The contributing process documentation is still in-progress. The numbered list b

After you've created a fork of this repository under your GitHub account, and cloned your fork to your machine, the contribution flow looks like:

1. Create a new branch from `main`
2. Make changes and commit them to your branch
3. Create a PR with your branch against this repo's `main`
4. Request review(s) of your PR
5. Allow at least 24-48 hours for review
6. Address any review comments
7. Repeat steps 4-6 as needed
8. Allow your PR to be approved & merged
9. Celebrate! 🎉
1. Pick a [repo issue](https://github.com/React-Indy/website/issues) to work on.
2. Create a new branch from `main`
3. Make changes and commit them to your branch
4. Create a PR with your branch against this repo's `main`
1. [Link the PR to the issue using a keyword.](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
2. Ex: `Made header image responsive. Fixes React-Indy/website#5`
5. Request review(s) of your PR
6. Allow at least 24-48 hours for review
7. Address any review comments
8. Repeat steps 4-6 as needed
9. Allow your PR to be approved & merged
10. Celebrate! 🎉

### 1b. Related resources

Expand All @@ -43,4 +46,4 @@ The following commands should be run with your chosen command line application f

1. Run `npm install` to install project dependencies
2. Run `npm start` to start the app in development mode
3. Go to http://localhost:3000/ in your web browser
3. Go to [http://localhost:3000/](http://localhost:3000) in your web browser
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/pages/index.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
.header {
background-color: var(--color-eerie-black);

& img {
& > img {
height: auto;
width: 100%;
max-width: 1000px;
margin: 0 auto;
}
Expand Down
1 change: 1 addition & 0 deletions src/pages/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const HomePage = () => {
<Image
alt="logo"
src={heroImage}
sizes="100vw"
/>
</header>
<main className={classNames("flow", styles.main)}>
Expand Down

0 comments on commit e045510

Please sign in to comment.