Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Zuljeah v0.1beta1 #1392

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hemisphera
Copy link

First release

@hemisphera
Copy link
Author

Just wondering ... it's been sitting here for 1 month now. Is there anything that I'm missing for this to move on?

if (v["start"] <= pos) and (v["end"] >= pos) then
v["mediaitem"] = mi
v["selected"] = reaper.IsMediaItemSelected(mi)
sortedRegions[seq] = v
Copy link
Member

@cfillion cfillion Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay... Tried it out: it crashes on this line (seq is nil) if P_NOTES fails to parse as a number.

The 'Consolas' font is only pre-installed on Windows.

The user-facing actions should have the author prefix and be named as sentence case (eg. "hemisphera_Zuljeah - Next song.lua") to blend well with other actions.

Since all three Lua files share a lot of code, I recommend putting the common code in one file and loading that from the others instead of duplicating. A good place would be the hemisphera_Zuljeah.lua package file (in which case it needs to be marked for installation, but not listed in the action list).

Is this behavior normal when starting playback after moving the cursor a bit before the regions?
Take

Docker #0 may be anywhere (top/bottom/left/right/floating), so it would be best to persist in which docker the user wants to put the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants