Release Reduce interactively the number of events in Midi CC lanes v1.0.1 #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfillion
reviewed
Oct 31, 2024
| //GetAppVersion(#reaper_version); | ||
| //strnicmp(#reaper_version, "6.24", 4) >=0 && APIExists("JS_Window_Find") ? ( | ||
| (APIExists("JS_Window_Find") && APIExists("JS_Window_AttachTopmostPin")) ? ( | ||
| JS_Window_AttachTopmostPin(JS_Window_Find(SCRIPT_NAME, true)); |
There was a problem hiding this comment.
Sorry for the long delay. This fails to parse if js_ReaScript API is not installed. This should use the extension_api("JS_Window_...", ...) syntax instead.
If the name of the script is just "Trim CCs", then the filename should be "rig_Trim CCs.eel" and @description should be "Trim CCs" to match.
The documentation mention adding the script to the MIDI Editor section, but the package is configured to add the script to the Main section only. Consider registering the script to the MIDI Editor section or both sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc changes