Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for release #197

Merged
merged 5 commits into from
Feb 27, 2023
Merged

prepare for release #197

merged 5 commits into from
Feb 27, 2023

Conversation

kevinushey
Copy link
Contributor

No description provided.

@kevinushey
Copy link
Contributor Author

FYI @Enchufa2; I will unfortunately have to back out the TBB auto-detection for the upcoming RcppParallel release.

The current version of rstan / StanHeaders on CRAN tries to use some TBB APIs which have been removed from the most recent TBB release. Unfortunately, the CRAN machines have a system installation of this new version of TBB installed, which is hence not compatible with the version of StanHeaders currently on CRAN. Which means auto-detecting and using that copy of TBB causes RcppParallel to fail its reverse dependency checks.

You can still turn it on by setting the environment variable TBB_AUTODETECT=TRUE when installing RcppParallel, but for now we'll still default to using the older, bundled version.

@eddelbuettel
Copy link
Member

For what it worth I always found @bgoodri to respond well and accomodate requests for updates; I usually have those from RcppEigen. Stan being its own ecosystem these things tend to take a moment but it might be something to consider for the next release.

With that, thanks as always for looking after RcppParallel. It's a challenging package.

@kevinushey kevinushey merged commit 769a4e2 into master Feb 27, 2023
@bgoodri
Copy link

bgoodri commented Feb 27, 2023

@kevinushey Which APIs are being used by Stan that no longer exist in TBB?

@kevinushey
Copy link
Contributor Author

kevinushey commented Feb 27, 2023

@bgoodri I created an issue here: stan-dev/rstan#1041

As I understand it, TBB's task scheduler is now deprecated, and the newest release of TBB no longer includes the tbb/task_scheduler_init.h header, which is used in StanHeaders in stan/math/prim/core/init_threadpool/tbb.hpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants