Skip to content

Commit

Permalink
MDBF-746 - Galera test suite should run even if the previous test sui…
Browse files Browse the repository at this point in the history
…tes failed

- added dependency for Galera test steps so they will not depend upon other test suites results but on Compile.
- previously the MTR step for galera was named "test" and was not obvious what we're testing.
  • Loading branch information
RazvanLiviuVarzaru committed Jul 11, 2024
1 parent 00dd033 commit af4b5a8
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions common_factories.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,14 @@ def getBuildFactoryPreTest(build_type="RelWithDebInfo", additional_args=""):
haltOnFailure="true",
)
)

f_quick_build.addStep(
steps.SetProperty(
name="mark compile step as completed",
property="compile_step_completed",
value=True,
)
)
return f_quick_build


Expand Down Expand Up @@ -301,6 +309,8 @@ def addTests(
def addGaleraTests(factory, mtrDbPool):
factory.addStep(
steps.MTR(
name="Galera tests",
alwaysRun=True,
description="testing galera",
descriptionDone="test galera",
logfiles={"mysqld*": "./buildbot/mysql_logs.html"},
Expand All @@ -325,7 +335,7 @@ def addGaleraTests(factory, mtrDbPool):
dbpool=mtrDbPool,
autoCreateTables=True,
env=mtrEnv,
doStepIf=hasGalera,
doStepIf=hasGalera and util.Property("compile_step_completed", default=False),
)
)
factory.addStep(
Expand All @@ -342,7 +352,7 @@ def addGaleraTests(factory, mtrDbPool):
jobs=util.Property("jobs", default="$(getconf _NPROCESSORS_ONLN)"),
),
],
doStepIf=hasGalera,
doStepIf=hasGalera and util.Property("compile_step_completed", default=False),
)
)
return factory
Expand Down

0 comments on commit af4b5a8

Please sign in to comment.