Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set REACT_APP _API_ENDPOINT and _AUTHENTICATION_URL as props #1124

Merged
merged 24 commits into from
Nov 5, 2024
Merged

set REACT_APP _API_ENDPOINT and _AUTHENTICATION_URL as props #1124

merged 24 commits into from
Nov 5, 2024

Conversation

conorriches
Copy link
Member

@conorriches conorriches commented Oct 23, 2024 •
edited
Loading

Issue

Closes https://github.com/RaspberryPiFoundation/learner-experience-integration-tests/issues/5

Description

  • Changed how both utils function:
    • src/utils/apiCallHandler.js
    • src/utils/userManager.js
  • I've considered how best to adapt these helpers - I could have gone with classes or functions, and while I considered changing these to be classes, this would require more verbose invocation throughout the codebase which ended up making code harder to read, whereas the function-based approach means most calls can be left as-is.
  • public/index.html added which provides a handy link to the web-component.html rather than just a directory listing
  • Removed a load of code that isn't used any more

sra405 and others added 4 commits October 29, 2024 12:16
@sra405 @conorriches
Py-enigma-support (#1109)
7bb4f5e 
Annoyingly py-enigma is relatively old and unmaintained but regularly
used in platforms like Ada. The maintainer hasn't included a wheel in
the distribution so can't be dynamically installed via micropip. I built
one from the `tar.gz` file instead and included alongside or other
custom install packages using the command:
```
python -m pip wheel https://files.pythonhosted.org/packages/91/4e/44327ad4a5960de12d86d39e1797f3ab67396a17d82182e8fc1b5ef347e5/py-enigma-0.1.tar.gz
```
where the `tar.gz` file location came from the location in PyPI -
https://pypi.org/project/py-enigma/#files
@create-issue-branch @loiswells97 @conorriches
Editor project image too large (#1126)
ad705b1 
closes #1115

---------

Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com>
Co-authored-by: Lois Wells <[email protected]>
@loiswells97 @conorriches
v0.28.5 (#1127)
41b2650 
### Fixed

- Image sizing and wrapping in the sidebar (#1126)
@conorriches
Merge branch 'main' into feat/paramaterise-env-vars
d0b0bd0
@conorriches conorriches marked this pull request as ready for review October 31, 2024 15:20
@conorriches conorriches changed the title move REACT_APP_API_ENDPOINT and REACT_APP_AUTHENTICATION_URL out of f… set REACT_APP _API_ENDPOINT and _AUTHENTICATION_URL as props Oct 31, 2024
sra405
sra405 reviewed Nov 5, 2024
View reviewed changes
src/web-component.html Outdated Show resolved Hide resolved
sra405
sra405 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@sra405 sra405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 this is awesome!

@conorriches conorriches merged commit 817e28c into main Nov 5, 2024
8 checks passed
@conorriches conorriches deleted the feat/paramaterise-env-vars branch November 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sra405 sra405 sra405 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorriches @sra405 @loiswells97