Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak some default parameters #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tweak some default parameters #329

wants to merge 1 commit into from

Conversation

jakobnissen
Copy link
Member

Benchmarking has suggested than on the current version of Vamb, these parameters may be better.
This needs additional benchmarking.

I'm making this PR now so we don't forget. Importantly things to consider

  • We should also test the optimal value of alpha for single-sample binning. This may have changed in recent versions of Vamb.
  • The benchmarking for this PR is done on long reads. This may cause the optimal alpha to be overestimated. Confirm that a=0.25 is better for short reads, too.
  • Since beta needed to be increased, we may consider upping the number of neurons in the latent layers, too.
  • We should check the log files to see how much slower a starting batch size of 128 is compared to one of 256, on a dataset with longer reads. If the gain is sufficiently small, and the compute time large, we may skip this optimisation.

This also interacts with #180 which we still need to do.

Benchmarking has suggested than on the current version of Vamb, these parameters
may be better.
This needs additional benchmarking.
@jakobnissen jakobnissen added the Needs benchmark Must benchmark before merging this label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs benchmark Must benchmark before merging this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants