-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
order of function call corrected. On similar lines of rasa-sdk #13023
base: main
Are you sure you want to change the base?
order of function call corrected. On similar lines of rasa-sdk #13023
Conversation
|
Hi @gajendrarao1979, thank you for the pull request! Can you please describe the changes you've made and why are they required? |
@vcidst The configure_colored_logging function leverages coloredlogs module which discards and reinitializes logging.StreamHandler. Essentially this overwrites any changes coming from logging.yml (if someone is using StreamHandler). In my PR I have updated the order of the function call to ensure that logging.yml changes are not overwritten. This is already correct in rasa-sdk code. I hope this provides the explanation. |
@vcidst Any updates on this? |
Necessary change for using on a production system where observability matters. Hoping to see this PR merged soon! |
Hey @gajendrarao1979, we won't be able to merge these PRs as this repository isn't under active maintenance anymore. Please see this page for our product releases and maintenance policy |
Hi @vcidst, could you please clarify why this PR won't be merged? I've read the maintenance policy page you referenced and I can't see any mention of Rasa Open Source being deprecated. Is there an announcement from Rasa anywhere that the open source version is no longer maintained? Thanks! |
@vcidst can you please comment on this? If RASA Opensource is no longer maintained then we need to find alternate solution. |
@arththebird , @pdelagrave One workaround which we did to circumvent this issues is re-initialized logging in custom-channel code which gets executed after rasa initialization (not ideal but works until the fix in the library is available.) |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)