Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[commands] Add SoundboardSoundConverter #9973

Merged
merged 4 commits into from
Oct 13, 2024
Merged

[commands] Add SoundboardSoundConverter #9973

merged 4 commits into from
Oct 13, 2024

Conversation

z03h
Copy link
Contributor

@z03h z03h commented Oct 12, 2024

Summary

Adds SoundboardSoundConverter

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented Oct 12, 2024

Out of curiosity did anyone ask for this or is this just there for completion?

@z03h
Copy link
Contributor Author

z03h commented Oct 12, 2024

Mostly for completion. I was playing around with sounds and noticed there wasn't a converter

@Rapptz Rapptz merged commit 442ad40 into Rapptz:master Oct 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z03h @Rapptz