Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Forwarding #9950

Merged
merged 41 commits into from
Oct 11, 2024
Merged

Message Forwarding #9950

merged 41 commits into from
Oct 11, 2024

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented Sep 29, 2024 •
edited
Loading

Summary

redmvc said in #9892 they will not be able to continue with the PR anytime soon so I've continued their work in this PR.

This has all the previous changes in addition of:

  • PartialMessage.forward(...) method for message forwarding
  • MessageReference constructor not a breaking change
  • Moved MessageSnapshot from "Data Classes" section to "Discord Models"
  • Added MessageReferenceType enum to docs
  • .. versionadded::s where it was missing.

Related Discord API Docs PRs:

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

DA-344 and others added 30 commits March 20, 2024 10:59
@DA-344
Added warning for my fork :v
6f9f5d6
@redmvc
Create message reference type
6561f74 
Create enums and class attributes tracking the type of a message reference (default or forward)
@redmvc
Create MessageSnapshot class
43e0fd2 
Create a class to track a snapshot of a message
@redmvc
Store list of message snapshots in message
0c6eb9e
@redmvc
Add MessageSnapshot to exported classes
7b7dd83 
Add class MessageSnapshot to classes exported from message.py
@redmvc
Remove trailing spaces
cc10a75
@redmvc
Add MessageSnapshit to api.rst
4c65968
@redmvc
Typo fix
57f5949
@redmvc
Remove incorrect documentation
ea5763b
@redmvc
Add MessageSnapshot to api.rst
6ed45c1
@redmvc
Typo fix
46d157c
@redmvc
Remove incorrect documentation
aa01eca
@redmvc
Merge branch 'feature/message_snapshots' of https://github.com/redmvc…
6a7933c 
…/discord.py into feature/message_snapshots
@redmvc
Use MessageReferenceType in MessageReference initialiser
6867dc6
@redmvc
Rename MessageSnapshot's timestamp to created_at
e58f341
@redmvc
Create edited_at property in MessageSnapshot
756f6c6
@redmvc
Add missing line break
6459700
@redmvc @MCausc78
Pass 0 to try_enum in MessageReference.with_state()
15b54ff 
Co-authored-by: MCausc78 <[email protected]>
@redmvc
Use type directly in MessageReference init
73c6904
@redmvc
Format message.py
bf1762c
@redmvc
Move MessageReferenceType definition
8da22c0 
Move MessageReferenceType definition in types/message.py above MessageReference typed dict
@redmvc @owocado
Replace "snapshotted" with "forwarded" in docstrings
3e9abf4 
Co-authored-by: owocado <[email protected]>
@DA-344
Changes
85969e1
@DA-344
Merge branch 'master' of https://github.com/Rapptz/discord.py into fe…
05da044 
…at/forwarding
@DA-344
Moved MessageSnapshot to Discord Models
00de465
@DA-344
Removed trailing whitespace
f25b177
@DA-344
Added MessageReferenceType enum
893730e
@DA-344
Removed invalid escape sequence and formatted with black
0f29fb1
@DA-344
Added components and stickers to message snapshot
41e0cca
@DA-344
Added stickers & components to attributes docs
7ed8568
DA-344 and others added 4 commits September 29, 2024 22:00
@DA-344
Changes
46ab672 
- MessageSnapshot.cached_message now returns the correct message
- MessageReference.to_dict now passes type for forwards
- PartialMessage.forward does not raise errors thanks to the already mentioned fix
@DA-344
Run black
2f9940f
@DA-344
Update PartialMessage.forward
17ab276
@DA-344
Added missing versionadded
081d4f7
@Rapptz Rapptz mentioned this pull request Oct 9, 2024
Closed
6 tasks
Rapptz
Rapptz reviewed Oct 9, 2024
View reviewed changes
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but there are unfortunately merge conflicts.

discord/enums.py Outdated Show resolved Hide resolved
Rapptz
Rapptz requested changes Oct 9, 2024
View reviewed changes
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot this PR also introduces instances of Optional[List[X]].

discord/message.py Outdated Show resolved Hide resolved
@DA-344
Copy link
Contributor Author

DA-344 commented Oct 10, 2024

Merge conflicts have been resolved and suggestions have been commited, PR is now ready to be merged.

@Rapptz
Copy link
Owner

Rapptz commented Oct 10, 2024

This has conflicts again.

@DA-344
Copy link
Contributor Author

DA-344 commented Oct 11, 2024

Fixed merge conflicts again.

@Rapptz Rapptz merged commit 99a7093 into Rapptz:master Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rapptz Rapptz Rapptz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DA-344 @Rapptz @redmvc