Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all channel clone implementations #9935

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Update all channel clone implementations #9935

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15800c4
Update all clone implementations
Soheab Sep 4, 2024
64f90e3
Run black
Soheab Sep 4, 2024
eee4902
Same fields cannot take null
Soheab Sep 4, 2024
a936c70
Fix fields for ForumChannel
Soheab Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 45 additions & 10 deletions discord/channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,15 @@ async def edit(self, *, reason: Optional[str] = None, **options: Any) -> Optiona
@utils.copy_doc(discord.abc.GuildChannel.clone)
async def clone(self, *, name: Optional[str] = None, reason: Optional[str] = None) -> TextChannel:
return await self._clone_impl(
{'topic': self.topic, 'nsfw': self.nsfw, 'rate_limit_per_user': self.slowmode_delay}, name=name, reason=reason
{
'topic': self.topic,
'rate_limit_per_user': self.slowmode_delay,
'nsfw': self.nsfw,
'default_auto_archive_duration': self.default_auto_archive_duration,
'default_thread_rate_limit_per_user': self.default_thread_slowmode_delay,
},
name=name,
reason=reason,
)

async def delete_messages(self, messages: Iterable[Snowflake], *, reason: Optional[str] = None) -> None:
Expand Down Expand Up @@ -1249,6 +1257,24 @@ async def create_webhook(self, *, name: str, avatar: Optional[bytes] = None, rea
data = await self._state.http.create_webhook(self.id, name=str(name), avatar=avatar, reason=reason)
return Webhook.from_state(data, state=self._state)

@utils.copy_doc(discord.abc.GuildChannel.clone)
async def clone(self, *, name: Optional[str] = None, reason: Optional[str] = None) -> Self:
base = {
'bitrate': self.bitrate,
'user_limit': self.user_limit,
'rate_limit_per_user': self.slowmode_delay,
'nsfw': self.nsfw,
'video_quality_mode': self.video_quality_mode.value,
}
if self.rtc_region:
base['rtc_region'] = self.rtc_region

return await self._clone_impl(
base,
name=name,
reason=reason,
)


class VoiceChannel(VocalGuildChannel):
"""Represents a Discord guild voice channel.
Expand Down Expand Up @@ -1343,10 +1369,6 @@ def type(self) -> Literal[ChannelType.voice]:
""":class:`ChannelType`: The channel's Discord type."""
return ChannelType.voice

@utils.copy_doc(discord.abc.GuildChannel.clone)
async def clone(self, *, name: Optional[str] = None, reason: Optional[str] = None) -> VoiceChannel:
return await self._clone_impl({'bitrate': self.bitrate, 'user_limit': self.user_limit}, name=name, reason=reason)

@overload
async def edit(self) -> None:
...
Expand Down Expand Up @@ -1588,10 +1610,6 @@ def type(self) -> Literal[ChannelType.stage_voice]:
""":class:`ChannelType`: The channel's Discord type."""
return ChannelType.stage_voice

@utils.copy_doc(discord.abc.GuildChannel.clone)
async def clone(self, *, name: Optional[str] = None, reason: Optional[str] = None) -> StageChannel:
return await self._clone_impl({}, name=name, reason=reason)

@property
def instance(self) -> Optional[StageInstance]:
"""Optional[:class:`StageInstance`]: The running stage instance of the stage channel.
Expand Down Expand Up @@ -2387,8 +2405,25 @@ def is_media(self) -> bool:

@utils.copy_doc(discord.abc.GuildChannel.clone)
async def clone(self, *, name: Optional[str] = None, reason: Optional[str] = None) -> ForumChannel:
base = {
'topic': self.topic,
'rate_limit_per_user': self.slowmode_delay,
'nsfw': self.nsfw,
'default_auto_archive_duration': self.default_auto_archive_duration,
'available_tags': [tag.to_dict() for tag in self.available_tags],
'default_thread_rate_limit_per_user': self.default_thread_slowmode_delay,
}
if self.default_sort_order:
base['default_sort_order'] = self.default_sort_order.value
if self.default_reaction_emoji:
base['default_reaction_emoji'] = self.default_reaction_emoji._to_forum_tag_payload()
if not self.is_media() and self.default_layout:
base['default_forum_layout'] = self.default_layout.value

return await self._clone_impl(
{'topic': self.topic, 'nsfw': self.nsfw, 'rate_limit_per_user': self.slowmode_delay}, name=name, reason=reason
base,
name=name,
reason=reason,
)

@overload
Expand Down
Loading