Fix error when app_commands.Group
misses a name
#9581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When creating a slash group through this syntax:
TypeError
will be raised, indicating that the group misses adescription
.Traceback
Traceback (most recent call last):
File "C:\Users\User\Desktop\testty\main.py", line 26, in
class Cog(commands.Cog):
File "C:\Users\User\Desktop\testty\main.py", line 27, in Cog
group = app_commands.Group(name="a")
File "C:\Users\User\Desktop\testty\.venv\lib\site-packages\discord\app_commands\commands.py", line 1549, in __init__
raise TypeError('groups must have a description')
TypeError: groups must have a description
This instead raises an error when trying to encode the name while syncing, which is
MISSING
:The intended behaviour is for the name to be the class name when subclassing
app_commands.Group
, but since this isn't a subclass, it doesn't work.This PR proposes to raise an error similar to the "missing description" one. This should not impact the creation of slash groups in any way while creating them through subclassing since the name is already set to the class name.
Checklist