Fix localization support for hybrid group fallback #9514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes localization support for the
HybridGroup
's fallback command and allows thefallback=
parameter to accept alocale_str
instance.Cause
It appears the original implementation did not change the
HybridAppCommand._name_locale
attribute, causing the fallback command to mistakenly use the parent group's name localizations. It also bypassed theapp_commands.Command
constructor which would have preventedauto_locale_strings=True
from localizing the fallback name had the previous bug been fixed.Checklist