Enable RBD PVC VolSync support and ensure tmp source PVCs accessModes #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BenamarMk
commented
Dec 24, 2024
BenamarMk
commented
- Enable VolSync protection on any PVC type through a DRPC annotation.
- Restrict ReadOnlyMany accessMode to temporary source CephFS PVCs.
- For non-Cephfs PVCs, the temporary source PVCs now inherit the accessModes of the source PVC (e.g., ReadWriteOnce or ReadWriteMany) instead of always ReadOnlyMany.
- On fresh deployment, delay the creation of tmp PVCs for consistency groups until the sync scheduled time.
BenamarMk
force-pushed
the
rbd-pvc-volsync-support
branch
from
eef345f to
dd47974
Compare
added 5 commits
December 24, 2024 03:15
VolSync protection can now be enabled for any PVC type by adding a specific annotation to the DRPC. Signed-off-by: Benamar Mekhissi <[email protected]>
Previously, temporary PVCs for all storage types were being created with the ReadOnlyMany access mode. This commit ensures that only CephFS temporary PVCs will use the ReadOnlyMany access mode. Additionally, the need for a special storage class tagged for backingSnapshot has been removed. Instead, the same storage class used for ReadWriteMany will now be used to create temporary ReadOnlyMany PVCs, simplifying the storage configuration. Signed-off-by: Benamar Mekhissi <[email protected]>
For non-CephFS PVCs, temporary PVCs now inherit the accessModes of the source PVC rather than using ReadOnlyMany. Signed-off-by: Benamar Mekhissi <[email protected]>
For consistency groups, temporary PVCs will now be created at the scheduled time rather than immediately upon fresh deployment. Signed-off-by: Benamar Mekhissi <[email protected]>
Signed-off-by: Benamar Mekhissi <[email protected]>
BenamarMk
force-pushed
the
rbd-pvc-volsync-support
branch
from
dd47974 to
0b72470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.