Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix extra linter errors #1730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raghavendra-talur
Copy link
Member

@raghavendra-talur raghavendra-talur commented Dec 20, 2024

These errors were discovered when running some extra linters which are not part of the default suite. I will enable the extra linters in a different PR.

Signed-off-by: Raghavendra Talur <[email protected]>
Copy link
Member

@asn1809 asn1809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ShyamsundarR
Copy link
Member

@raghavendra-talur with this golang change in play, how does it impact some of the changes in this PR?

@ShyamsundarR
Copy link
Member

@raghavendra-talur with this golang change in play, how does it impact some of the changes in this PR?

Looks like the fix attempts to address this failure. It is possible that the linters downstream are older, and hence "complaining" about the same. One option is to address this downstream only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants