create RS irrespective of PV mount status.

[pruthvitd]

Fix for [2319824] [RDR] Replication via Volsync requires PVC to be mounted before PVC is synchronized
* Create ReplicationSource irrespective of PV being mounted to running pod.
* Renamed "validatePVCBeforeRS" as "validatePVCForFinalSync"

[pruthvitd]

How this is tested:

(ramen) [root@ramen1 samples]# kubectl scale deployment/busybox --replicas=0 -n deployment-cephfs --context dr1
deployment.apps/busybox scaled
(ramen) [root@ramen1 samples]# kubectl get replicationsource -A --context dr1
NAMESPACE           NAME          SOURCE        LAST SYNC              DURATION        NEXT SYNC
deployment-cephfs   busybox-pvc   busybox-pvc   2024-12-12T16:54:40Z   40.696555939s   2024-12-12T16:55:00Z
(ramen) [root@ramen1 samples]# kubectl delete replicationsource busybox-pvc -n deployment-cephfs  --context dr1
replicationsource.volsync.backube "busybox-pvc" deleted
(ramen) [root@ramen1 samples]# kubectl get po -n deployment-cephfs --context dr1
NAME                                      READY   STATUS    RESTARTS   AGE
volsync-rsync-tls-src-busybox-pvc-5kb8n   0/1     Pending   0          1s
(ramen) [root@ramen1 samples]# kubectl get po -n deployment-cephfs --context dr1
No resources found in deployment-cephfs namespace.
(ramen) [root@ramen1 samples]# kubectl get replicationsource -A --context dr1
NAMESPACE           NAME          SOURCE        LAST SYNC              DURATION        NEXT SYNC
deployment-cephfs   busybox-pvc   busybox-pvc   2024-12-12T16:57:34Z   34.517990544s   2024-12-12T16:58:00Z

ramen-dr-cluster-operator pod log:

[1] 588806
(ramen) [root@ramen1 ramen]# grep "PVC is not in use by ready pod, yet creating RS ..." /root/DR/samples/dr1-ramen.log
2024-12-12T16:55:11.923Z	INFO	controllers.VolumeReplicationGroup	volsync/vshandler.go:399	PVC is not in use by ready pod, yet creating RS ...	{"VolumeReplicationGroup": {"name":"deployment-cephfs-drpc","namespace":"deployment-cephfs"}, "rid": "14afb717-e7a4-4367-a85c-b31b207693a6", "rsSpec": {"protectedPVC":{"namespace":"deployment-cephfs","name":"busybox-pvc","protectedByVolSync":true,"storageID":{"id":""},"replicationID":{"id":""},"storageClassName":"rook-cephfs","annotations":{"apps.open-cluster-management.io/hosting-subscription":"deployment-cephfs/subscription","apps.open-cluster-management.io/reconcile-option":"merge"},"labels":{"app":"deployment-cephfs","app.kubernetes.io/part-of":"deployment-cephfs","appname":"busybox"},"accessModes":["ReadWriteMany"],"resources":{"requests":{"storage":"1Gi"}},"conditions":[{"type":"ReplicationSourceSetup","status":"True","observedGeneration":1,"lastTransitionTime":"2024-12-12T16:37:47Z","reason":"SourceInitialized","message":"Ready"}],"volumeMode":"Filesystem"}}, "runFinalSync": false}

[nirs]

I would use same log, just change the part describing the pvc:

PVC is use by ready pod, proceeding to create RS"
PVC is not used by ready pod, proceeding to create RS"

The "..." part is not helpful, so you can remove it while changing the logs. It can also be done in a preparation commit to keep one logic change for every commit.

Since we don't skip if inUseByReadyPod is false, we can use more natual check:

if inUseByReadyPod {
    log for used pvc...
} else {
    log for unused pvc ...
}

[BenamarMk]

I would just replace all lines from line 370 to 399 and replace it with this:

_, err := v.getRS(getReplicationSourceName(rsSpec.ProtectedPVC.Name), rsSpec.ProtectedPVC.Namespace)
if err != nil {
    if !kerrors.IsNotFound(err) {
        return false, err
    }
}

return true, nil

[BenamarMk]

If you want to log here, just say "ReplicationSource does not exist". If you say "creating it now" it implies that this function will create it. But this function does do that. So I would ignore that part.

[ELENAGER]

LGTM

[BenamarMk]

The last thing is to remove this comment

[BenamarMk]

LGTM.
Thanks @pruthvitd