Check hook additional changes #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn1809
requested review from
BenamarMk,
nirs,
raghavendra-talur and
ShyamsundarR
ELENAGER
reviewed
Dec 15, 2024
|
|
||
| if err != nil { | ||
| log.Info("error executing check hook", "for", hook.Name, "with error", err) | ||
| errOut = err |
There was a problem hiding this comment.
@asn1809 , when we have real failure here, I mean not res = false, but err is not empty, do we need to proceed in this loop?
There was a problem hiding this comment.
Thanks @ELENAGER, the reason is to fail the hook if any of the checks fail. For example, suppose a labelSelector or nameSelector returns 2 Deployments, and check hook passes for one and fails for other, then overall check hook should be marked as failed. Let me know if you see any issues.
There was a problem hiding this comment.
@Annaraya-Narasagond , exactly, maybe just
return false, err
in line 83?
For check hooks to be executed for the resource type pod, deployment or statefulset, either nameSelector or labelSelector are mandatory. nameSelector can be: 1. Distinct name which will match with exact name of the resource. 2. Regex, which may match with multiple resources. labelSelector spec is according to meta/v1. If multiple resources are found, then check hook will be executed on all the resources and res will be logged for each of the resource. Signed-off-by: Annaraya Narasagond <[email protected]>
asn1809
force-pushed
the
asn-check-hook
branch
from
93c0b32 to
d8d2b89
Compare
Signed-off-by: Annaraya Narasagond <[email protected]>
Signed-off-by: Annaraya Narasagond <[email protected]>
Signed-off-by: Annaraya Narasagond <[email protected]>
Signed-off-by: Annaraya Narasagond <[email protected]>
Signed-off-by: Annaraya Narasagond <[email protected]>
Signed-off-by: Annaraya Narasagond <[email protected]>
raghavendra-talur
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697