Refactor vrg-kubeobject functions #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavendra-talur
requested review from
asn1809,
nirs,
ShyamsundarR and
BenamarMk
raghavendra-talur
changed the title
raghavendra-talur
changed the title
raghavendra-talur
force-pushed
the
rtalur-simplify-ExecuteRecoverGroup
branch
from
71e670d to
ffce5e1
Compare
raghavendra-talur
force-pushed
the
rtalur-simplify-ExecuteRecoverGroup
branch
from
8c8c4d0 to
395bd2a
Compare
|
@BenamarMk This PR is ready for review. I have rebased it on top of #1709 so the e2e failures should be gone. |
ELENAGER
reviewed
Dec 12, 2024
BenamarMk
reviewed
Dec 13, 2024
| if v.kubeObjectProtectionDisabled("recovery") { | ||
| return nil | ||
| } | ||
| func (v *VRGInstance) getVRGFromS3Profile(s3ProfileName string) (*ramen.VolumeReplicationGroup, error) { |
There was a problem hiding this comment.
We have this function: GetLastKnownVRGPrimaryFromS3. Can we have a common function?
There was a problem hiding this comment.
@BenamarMk that is a function in DRPC and this is a function in VRG as a method on VRGInstance, can I take up the refactoring in a later PR?
- created methods for getting capture and recover requests - removed function parameters that can be obtained using v.instance. Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
- Remove `sourceVrgNamespaceName` and `sourceVrgName` as parameters. - Derive `sourceVrgNamespaceName` and `sourceVrgName` directly from the instance. Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
- Removed unnecessary local variable `localS3StoreAccessor` Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
- `getVRGFromS3Profile` gets the source vrg - call `getVRGFromS3Profile` from `kubeObjectsRecover` Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
…ore retrival - Updated the `findS3StoreAccessor` method to accept `s3ProfileName` directly - Removed unnecessary intermediate variable `localS3StoreAccessor` Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-simplify-ExecuteRecoverGroup
branch
from
395bd2a to
5d5170d
Compare
We were passing veleroNamespaceName through many functions where it can be obtained from the v object. Don't pass it as a parameter until the last call. Functions: - `getRecoverOrProtectRequest` - `kubeObjectsRecoveryStartOrResume` - `executeRecoverGroup` by removing the `veleroNamespaceName` parameter. Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-simplify-ExecuteRecoverGroup
branch
from
5d5170d to
c1cb4e1
Compare
Co-Authored-by: Annaraya Narasagond <[email protected]> Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-simplify-ExecuteRecoverGroup
branch
from
d5e747a to
f9d4955
Compare
ELENAGER
approved these changes
Dec 17, 2024
asn1809
approved these changes
Dec 17, 2024
ShyamsundarR
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the following functions