Propagate VR condition error message to protected pvc conditions #1639
+54
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenamarMk
reviewed
Nov 5, 2024
| @@ -8,5 +8,5 @@ resources: | |||
| - https://github.com/csi-addons/kubernetes-csi-addons/releases/download/v0.10.0/setup-controller.yaml | |||
|
|
|||
| images: | |||
| - name: quay.io/csiaddons/k8s-controller | |||
| newTag: v0.10.0 | |||
| - name: quay.io/ypadia/k8s-controller | |||
There was a problem hiding this comment.
Why are you checking in the development build path?
There was a problem hiding this comment.
Because I want to test this PR now:
csi-addons/kubernetes-csi-addons#691
There was a problem hiding this comment.
image kustomization fixed, it works now:
csi-addons/kubernetes-csi-addons#691 (comment)
nirs
force-pushed
the
vr-status
branch
2 times, most recently
from
d65c6eb
to
a84c11b
Compare
Using development build of csi-addons adding .Message to the all conditions. Signed-off-by: Nir Soffer <[email protected]>
nirs
changed the title
|
Works for VR conditions other then Validated. We propagate the messages form the VR conditions: VR: VRG: Missing change: when Validated condition is False, we want to set the DataReady condition and DataProtected using the error message from the Validated condition. Currently we use the Validated condition only for checking if the VR is finished and can be removed. |
nirs
force-pushed
the
vr-status
branch
3 times, most recently
from
19ac40b
to
a0d18cc
Compare
When condition is not met, we set the protected PVC condition message using the error message returned from isVRConditionMet(). When using csi-addons > 0.10.0, we use now the message from the condition instead of the default message. Since the Validated condition is not reported by older version of csi-addons, and ramen may run on a system with older csi-addons, isVRConditionMet() return now a boolean value telling if the check was successful; we found the condition, its observed generation matches the object generation, and its value is not Unknown. Since we want to propagate the message from the Validated condition, if Validate.Status was False, we set the DataReady and DataProtected using the Validated.Message, and skip checking the next conditions. If we could not check the Validated condition we continue to check the other conditions. Signed-off-by: Nir Soffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using development build of csi-addons adding .Message to the all conditions.