Map PV secrets in parameters when restoring PVs #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshgm
force-pushed
the
secrets-mask
branch
4 times, most recently
from
a32c87d
to
5245f52
Compare
There was a problem hiding this comment.
LGTM! Add a test for the mapping along the lines of this test
Keep the test as a separate PR for now, such that we can merge this in stages.
rakeshgm
force-pushed
the
secrets-mask
branch
from
e702cac
to
3cb0318
Compare
Map PV secrets in parameters when restoring PVs across peer clusters. Signed-off-by: rakeshgm <[email protected]>
create SC in the sync basic test Signed-off-by: rakeshgm <[email protected]>
rakeshgm
force-pushed
the
secrets-mask
branch
from
3cb0318
to
e1e279f
Compare
rakeshgm
changed the title
rakeshgm
changed the title
ShyamsundarR
approved these changes
Nov 5, 2024
|
e2e failure is related to #1557 |
Madhu-1
reviewed
Nov 5, 2024
| //nolint:gosec | ||
| const ( | ||
| // secretRef keys | ||
| controllerPublishSecretName = "csi.storage.k8s.io/controller-publish-secret-name" |
There was a problem hiding this comment.
What about the provisioner secrets that are present in pv annotation? Want we update that as well?
There was a problem hiding this comment.
Provisioner secrets are in PV annotations? I assume these are needed for Delete operations?
If so @rakeshgm add a new PR to update that as well.
There was a problem hiding this comment.
apiVersion: v1
items:
- apiVersion: v1
kind: PersistentVolume
metadata:
annotations:
pv.kubernetes.io/provisioned-by: rook-ceph.rbd.csi.ceph.com
volume.kubernetes.io/provisioner-deletion-secret-name: rook-csi-rbd-provisioner
volume.kubernetes.io/provisioner-deletion-secret-namespace: rook-ceph
creationTimestamp: "2024-11-05T09:51:09Z"
finalizers:Yes in the pv annotation for delete operation.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map PV secrets in parameters when restoring PVs across peer clusters