Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drenv: storage IDs on clusters must have unique names #1579

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

ELENAGER
Copy link
Member

This PR addresses the following comment: #1564 (comment)

@ELENAGER ELENAGER changed the title drenv: add cluster name to storage id drenv: storage IDs on clusters must have unique names Sep 30, 2024
Signed-off-by: Elena Gershkovich <[email protected]>
Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but lets waif for @ShyamsundarR

Copy link
Member

@ShyamsundarR ShyamsundarR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this is fine, if we have multiple rook-ceph clusters on the same host then this may need amends.

@ShyamsundarR ShyamsundarR merged commit 3fde1a1 into RamenDR:main Oct 7, 2024
19 of 20 checks passed
@ELENAGER ELENAGER deleted the sc_name branch October 7, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants