Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterClaim to the ramen-dr-cluster reconciler scheme #1574

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ShyamsundarR
Copy link
Member

This is required as the dr-cluster DRClusterConfig reconciler manages cluster claims.

This was missed out in commit 91e5a5b

This is required as the dr-cluster DRClusterConfig reconciler
manages cluster claims.

This was missed out in commit 91e5a5b

Signed-off-by: Shyamsundar Ranganathan <[email protected]>
@ShyamsundarR
Copy link
Member Author

Tested (in drenv) with and without this PR to reproduce errors like below (without the fix) and ensured fix works to remove the errors observed:

2024-09-25T16:32:25.312Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drclusterconfig", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRClusterConfig", "DRClusterConfig": {"name":"dr1"}, "namespace": "", "name": "dr1", "reconcileID": "00ecd0e9-c8f6-4369-a8d6-6aba7f1028c2", "error": "failed to create or update ClusterClaim storage.class.rook-ceph-block, no kind is registered for the type v1alpha1.ClusterClaim in scheme \"pkg/runtime/scheme.go:100\""}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:263
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:224

@ShyamsundarR ShyamsundarR merged commit 43077c8 into RamenDR:main Sep 26, 2024
19 of 20 checks passed
@ShyamsundarR ShyamsundarR deleted the ccliams_watch branch September 30, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants