adding storageID and replicationID to classes

add storageID, replicationID to StorageClass, replicationClasses and snapshotClasses. this is to faciltate filtering of multiple storageClasses Signed-off-by: rakeshgm <[email protected]>
RamenDR · Oct 30, 2024 · 2b8b3ac · 2b8b3ac
1 parent 67f473d
commit 2b8b3ac
Show file tree

Hide file tree

Showing 10 changed files with 71 additions and 24 deletions.
diff --git a/test/addons/rbd-mirror/start b/test/addons/rbd-mirror/start
@@ -106,6 +106,10 @@ def configure_rbd_mirroring(cluster, peer_info):
         context=cluster,
     )
 
+    template = drenv.template("vrc-sample.yaml")
+    yaml = template.substitute(cluster=cluster)
+    kubectl.apply("--filename=-", input=yaml, context=cluster)
+
     print(f"Apply rbd mirror to cluster '{cluster}'")
     kubectl.apply("--kustomize=start-data", context=cluster)
 

diff --git a/test/addons/rbd-mirror/start-data/kustomization.yaml b/test/addons/rbd-mirror/start-data/kustomization.yaml
@@ -3,7 +3,6 @@
 
 ---
 resources:
-- vrc-sample.yaml
 - vgrc-sample.yaml
 - rbd-mirror.yaml
 

diff --git a/test/addons/rbd-mirror/start-data/vrc-sample.yaml b/test/addons/rbd-mirror/start-data/vrc-sample.yaml
@@ -6,6 +6,9 @@ apiVersion: replication.storage.openshift.io/v1alpha1
 kind: VolumeReplicationClass
 metadata:
   name: vrc-sample
+  labels:
+    ramendr.openshift.io/storageid: rook-ceph-$cluster-1
+    ramendr.openshift.io/replicationid: rook-ceph-$cluster-1
 spec:
   provisioner: rook-ceph.rbd.csi.ceph.com
   parameters:

diff --git a/test/addons/rook-cephfs/cache b/test/addons/rook-cephfs/cache
diff --git a/test/addons/rook-cephfs/kustomization.yaml b/test/addons/rook-cephfs/kustomization.yaml
diff --git a/test/addons/rook-cephfs/snapshot-class.yaml b/test/addons/rook-cephfs/snapshot-class.yaml
@@ -0,0 +1,21 @@
+# SPDX-FileCopyrightText: The RamenDR authors
+# SPDX-License-Identifier: Apache-2.0
+
+# yamllint disable-line rule:line-length
+# Source: https://raw.githubusercontent.com/rook/rook/release-1.15/deploy/examples/csi/cephfs/snapshotclass.yaml
+# Modifications:
+#  - Added storageID and replicationID
+---
+apiVersion: snapshot.storage.k8s.io/v1
+deletionPolicy: Delete
+driver: rook-ceph.cephfs.csi.ceph.com
+kind: VolumeSnapshotClass
+metadata:
+  name: csi-cephfsplugin-snapclass
+  labels:
+    ramendr.openshift.io/storageid: rook-cephfs-$cluster-1
+    ramendr.openshift.io/replicationid: rook-cephfs-$cluster-1
+parameters:
+  clusterID: rook-ceph
+  csi.storage.k8s.io/snapshotter-secret-name: rook-csi-cephfs-provisioner
+  csi.storage.k8s.io/snapshotter-secret-namespace: rook-ceph
diff --git a/test/addons/rook-cephfs/start b/test/addons/rook-cephfs/start
@@ -7,14 +7,21 @@ import os
 import sys
 
 import drenv
-from drenv import cache
 from drenv import kubectl
 
 
 def deploy(cluster):
     print("Creating CephFS instance and storage/snapshot classes")
-    path = cache.get(".", "addons/rook-cephfs-1.15.yaml")
-    kubectl.apply("--filename", path, context=cluster)
+
+    kubectl.apply("--filename=filesystem.yaml", context=cluster)
+
+    template = drenv.template("storage-class.yaml")
+    yaml = template.substitute(cluster=cluster)
+    kubectl.apply("--filename=-", input=yaml, context=cluster)
+
+    template = drenv.template("snapshot-class.yaml")
+    yaml = template.substitute(cluster=cluster)
+    kubectl.apply("--filename=-", input=yaml, context=cluster)
 
 
 def wait(cluster):

diff --git a/test/addons/rook-cephfs/storage-class.yaml b/test/addons/rook-cephfs/storage-class.yaml
@@ -0,0 +1,27 @@
+# SPDX-FileCopyrightText: The RamenDR authors
+# SPDX-License-Identifier: Apache-2.0
+
+# yamllint disable-line rule:line-length
+# Source: https://raw.githubusercontent.com/rook/rook/release-1.15/deploy/examples/csi/cephfs/storageclass.yaml
+# Modifications:
+#  - Added storageID and replicationID
+---
+apiVersion: storage.k8s.io/v1
+kind: StorageClass
+metadata:
+  name: rook-cephfs
+  labels:
+    ramendr.openshift.io/storageid: rook-cephfs-$cluster-1
+provisioner: rook-ceph.cephfs.csi.ceph.com
+parameters:
+  clusterID: rook-ceph
+  fsName: myfs
+  pool: myfs-replicated
+  csi.storage.k8s.io/provisioner-secret-name: rook-csi-cephfs-provisioner
+  csi.storage.k8s.io/provisioner-secret-namespace: rook-ceph
+  csi.storage.k8s.io/controller-expand-secret-name: rook-csi-cephfs-provisioner
+  csi.storage.k8s.io/controller-expand-secret-namespace: rook-ceph
+  csi.storage.k8s.io/node-stage-secret-name: rook-csi-cephfs-node
+  csi.storage.k8s.io/node-stage-secret-namespace: rook-ceph
+reclaimPolicy: Delete
+allowVolumeExpansion: true
diff --git a/test/addons/rook-pool/snapshot-class.yaml b/test/addons/rook-pool/snapshot-class.yaml
@@ -8,6 +8,8 @@ apiVersion: snapshot.storage.k8s.io/v1
 kind: VolumeSnapshotClass
 metadata:
   name: csi-rbdplugin-snapclass
+  labels:
+    ramendr.openshift.io/storageid: rook-ceph-$cluster-1
 driver: rook-ceph.rbd.csi.ceph.com
 parameters:
   clusterID: rook-ceph

diff --git a/test/addons/rook-pool/start b/test/addons/rook-pool/start
@@ -22,10 +22,13 @@ def deploy(cluster):
     kubectl.apply("--filename=-", input=yaml, context=cluster)
     kubectl.apply(
         "--filename=replica-pool.yaml",
-        "--filename=snapshot-class.yaml",
         context=cluster,
     )
 
+    template = drenv.template("snapshot-class.yaml")
+    yaml = template.substitute(cluster=cluster)
+    kubectl.apply("--filename=-", input=yaml, context=cluster)
+
 
 def wait(cluster):
     print("Waiting until ceph block pool is ready")