Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure #18

Closed
wants to merge 11 commits into from
Closed

Restructure #18

wants to merge 11 commits into from

Conversation

RamblingCookieMonster
Copy link
Owner

Several changes:

  • Restructured paths, moving test material to a Tests folder, Invoke-Parallel.ps1 to it's own folder
  • Modified AppVeyor.yml to abstract out Pester invocation and test with both PowerShell 2 and the native version
  • Added verbose output to testing of branches not named master
  • Fixed PS2 test failure that cropped up. WarningVariable was not writing to a variable. Moved Timeout behavior from Warning to Error (seems appropriate? Presumably a timeout is a failure and indicative of an error state?)

Moved to psm1 and back to ps1 due to scope issues discussed in issue #16

Open to flipping things back, let me know if you have any concerns!

Cheers!

@vors
Copy link
Collaborator

vors commented Mar 4, 2015

Looks like LF / CRLF (line ending change) for me. It's very hard to review such changes, because you don't see the real diff :(

@RamblingCookieMonster
Copy link
Owner Author

Odd, I'm guessing it was the commit to change to psm1, commit to move back to ps1 (presumably it sees this as removing the ps1 and adding it fresh). Not sure what the right way to do this is, but I can create a fresh fork with existing files so that we only see diff from master to the current state.

@vors
Copy link
Collaborator

vors commented Mar 4, 2015

Removing and adding similar files counts as renaming. Such changes relate to line endings in 95% of cases. (and to tabs vs spaces in 4%)

@RamblingCookieMonster RamblingCookieMonster deleted the Restructure branch March 4, 2015 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants