-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to OpenXR 1.1.36 #158
Conversation
|
is there any ETA on this getting merged? |
It needs a rebase first, for one thing. |
Rebased now. The most glaring problem is that the instance cannot be created if OpenXR 1.1 isn't supported by the loader, as we try to use the current API version when creating the instance: Line 239 in 4681a25
|
Would it make sense to take a version argument, deferring that problem to the application? That'd help us gracefully handle movement of extensions that we provide high-level wrappers for into core, too. |
This runs with api version 1.0 now. I'm not sure what, if anything, is missing from the 1.1 spec. The only thing that disappeared when restricting the core commands to 1.0 was |
This PR builds upon #157.
The biggest change in the generator is that
<feature>
tags are processed now. They are similar to<extension>
but have a couple of important differences.<interaction_profiles>
were added in OpenXR 1.0.27 but we are still not using them. OpenXR 1.1.36 keeps building upon them with<extend>
and<interaction_profile>
tags inside<require>
tags. I think we should consider adding support for them in another PR.I used https://registry.khronos.org/OpenXR/specs/1.1/styleguide.html#schema and https://registry.khronos.org/vulkan/specs/1.3/registry.html to figure out the schema.