Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile mode #1948

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix profile mode #1948

merged 1 commit into from
Jul 17, 2024

Conversation

ReimuHakurei
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Fixes Profile mode: target temperature never settles #1939 -- this appears to most likely be a regression from baf2f26
    In addition to the bugs noted in that issue, I observed a couple of others that are also fixed here:

    • If two phases had the same target temperature, it would set the target to 0 degrees when hitting that phase.
    • The target temperature could underflow when cooling down.
    • The comment in the code indicated that it would reject entering profile mode if the actual temperature was greater than the defined preheat temperature, but the actual behavior was a hardcoded 55 C limit. I changed it to match what the comment said it should do.
  • What is the current behavior?

  • What is the new behavior (if this is a feature change)?

  • Other information:
    I tested this same patch on the branch for the Sequre T55, but as this is the only supported hotplate I own, I can't test this on the dev branch, as the T55 support has not been merged into dev yet.

@grinningmosfet
Copy link

Successfully tested on an MHP30.

@discip discip enabled auto-merge July 17, 2024 08:19
@discip discip requested a review from Ralim July 17, 2024 08:19
@discip discip merged commit 545d568 into Ralim:dev Jul 17, 2024
17 checks passed
@ReimuHakurei ReimuHakurei deleted the profile_fix branch July 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile mode: target temperature never settles
4 participants