Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinecil 2 PID tune adjustments #1925

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Pinecil 2 PID tune adjustments #1925

merged 2 commits into from
Jul 11, 2024

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Jun 8, 2024

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • [] There are no breaking changes
  • What kind of change does this PR introduce?

Creating builds to test different P/I setups

  • What is the current behavior?

  • What is the new behavior (if this is a feature change)?

  • Other information:

@discip
Copy link
Collaborator

discip commented Jun 21, 2024

@Ralim
What should I look for while testing this?

@Ralim
Copy link
Owner Author

Ralim commented Jun 22, 2024

Trying for more stability of the temperature control mostly. Ie it holds the setpoints temp better and less jittery

@discip discip marked this pull request as ready for review July 11, 2024 20:38
discip
discip approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@discip discip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to perform better now.
It's still jumpy to some extent, but for me it didn't exceed the target temp.

@Ralim Ralim merged commit db12683 into dev Jul 11, 2024
34 checks passed
@Ralim Ralim deleted the Pinecil-PID-tune branch July 11, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discip discip discip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ralim @discip